Skip to content

fix: don't fail the fallow-badge CI job on fallow's health exit code - #20

Merged
nnkogift merged 1 commit into
mainfrom
fix/fallow-badge-ci-exit-code
Aug 3, 2026
Merged

nnkogift merged 1 commit into
mainfrom
fix/fallow-badge-ci-exit-code

Conversation

@nnkogift

@nnkogift nnkogift commented Aug 3, 2026

Copy link
Copy Markdown
Owner

Summary

fallow-badge has been failing on every run since a recent fallow bump (visible on plain pushes to main, unrelated to any specific PR) — including on #19, unrelated to that PR's actual changes.

Root cause: fallow health --format badge exits with code 1 whenever it reports complexity findings, even though it still writes a valid SVG to stdout. Reproduced locally with the exact same shallow-clone conditions CI uses — the command succeeds in producing a correct badge, it just also happens to exit non-zero.

The badge job's only job is to publish that SVG; it was never meant to gate on the health score (there's no --min-score/--fail-on-issues flag set). This mirrors the sibling fallow job's pnpm exec fallow dead-code || true, which already tolerates the same class of behavior.

Test plan

  • Reproduced the failure locally in a fresh shallow clone (git clone --depth 1) matching CI's checkout
  • Verified pnpm exec fallow health --format badge > badge.svg || true exits 0 and still writes a valid, well-formed badge SVG

🤖 Generated with Claude Code

fallow health --format badge exits 1 whenever there are complexity
findings, even though it still writes a valid SVG to stdout. The badge
job only cares about publishing that SVG, not gating on the score, so
tolerate the exit code the same way the sibling fallow dead-code step
already does.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@nnkogift, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 49 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 3059e561-3016-4153-b5ea-d0aa6e32b3f6

📥 Commits

Reviewing files that changed from the base of the PR and between ece87d6 and d74b911.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved: Cursor Security Agent completed successfully with no findings requiring human review; Cursor Bugbot was not present on this PR. No reviewers assigned.

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Router and Approver

@nnkogift
nnkogift merged commit 5579092 into main Aug 3, 2026
13 of 14 checks passed
@nnkogift
nnkogift deleted the fix/fallow-badge-ci-exit-code branch August 3, 2026 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant