Repository navigation
fix: don't fail the fallow-badge CI job on fallow's health exit code - #20
Conversation
fallow health --format badge exits 1 whenever there are complexity findings, even though it still writes a valid SVG to stdout. The badge job only cares about publishing that SVG, not gating on the score, so tolerate the exit code the same way the sibling fallow dead-code step already does. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 49 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |


Summary
fallow-badgehas been failing on every run since a recentfallowbump (visible on plain pushes tomain, unrelated to any specific PR) — including on #19, unrelated to that PR's actual changes.Root cause:
fallow health --format badgeexits with code 1 whenever it reports complexity findings, even though it still writes a valid SVG to stdout. Reproduced locally with the exact same shallow-clone conditions CI uses — the command succeeds in producing a correct badge, it just also happens to exit non-zero.The badge job's only job is to publish that SVG; it was never meant to gate on the health score (there's no
--min-score/--fail-on-issuesflag set). This mirrors the siblingfallowjob'spnpm exec fallow dead-code || true, which already tolerates the same class of behavior.Test plan
git clone --depth 1) matching CI's checkoutpnpm exec fallow health --format badge > badge.svg || trueexits 0 and still writes a valid, well-formed badge SVG🤖 Generated with Claude Code