Repository navigation
targets/darwin/terminfo: compose TERMINFO_DIRS - #9862
Open
khaneliman wants to merge 1 commit into
Open
khaneliman wants to merge 1 commit into
khaneliman wants to merge 1 commit into
Conversation
khaneliman
force-pushed
the
session-vars-5-darwin-terminfo
branch
2 times, most recently
from
August 28, 2026 19:53
d475d1f to
66023f4
Compare
khaneliman
force-pushed
the
session-vars-5-darwin-terminfo
branch
2 times, most recently
from
August 28, 2026 20:58
7746326 to
b2d5568
Compare
khaneliman
force-pushed
the
session-vars-5-darwin-terminfo
branch
from
August 28, 2026 21:04
b2d5568 to
5e6aa03
Compare
khaneliman
force-pushed
the
session-vars-5-darwin-terminfo
branch
from
August 29, 2026 02:55
5e6aa03 to
f835d58
Compare
khaneliman
force-pushed
the
session-vars-5-darwin-terminfo
branch
from
August 29, 2026 04:20
f835d58 to
3d5556b
Compare
khaneliman
force-pushed
the
session-vars-5-darwin-terminfo
branch
2 times, most recently
from
August 29, 2026 13:30
c3c3372 to
bdb6986
Compare
khaneliman
force-pushed
the
session-vars-5-darwin-terminfo
branch
from
August 29, 2026 14:26
bdb6986 to
218bf80
Compare
khaneliman
force-pushed
the
session-vars-5-darwin-terminfo
branch
from
August 30, 2026 03:02
218bf80 to
d5e1fa1
Compare
khaneliman
force-pushed
the
session-vars-5-darwin-terminfo
branch
from
August 30, 2026 03:48
d5e1fa1 to
d0e61dd
Compare
khaneliman
marked this pull request as ready for review
August 30, 2026 03:50
khaneliman
force-pushed
the
session-vars-5-darwin-terminfo
branch
from
September 9, 2026 22:13
d0e61dd to
090f097
Compare
khaneliman
force-pushed
the
session-vars-5-darwin-terminfo
branch
from
September 11, 2026 03:12
090f097 to
e478275
Compare
khaneliman
force-pushed
the
session-vars-5-darwin-terminfo
branch
from
September 30, 2026 04:23
511d682 to
c577033
Compare
khaneliman
force-pushed
the
session-vars-5-darwin-terminfo
branch
2 times, most recently
from
October 1, 2026 02:11
2727a6c to
b10bf13
Compare
Build TERMINFO_DIRS from home.sessionSearchVariables and home.sessionSearchVariablesAppend instead of a self-referential home.sessionVariables value. On the first merge, place Home Manager's directory first and the system fallback last. Later merges preserve configured entries already present in TERMINFO_DIRS. Do not add duplicate configured entries. Add targets.darwin.terminfo.enable as the explicit opt-out. The prior home.sessionVariables.TERMINFO_DIRS override now composes with the module's paths instead of disabling them, so document the new opt-out in news. Run zsh test commands with -f because zsh reads .zshenv for -c commands. This prevents host session markers from bypassing test merges.
khaneliman
force-pushed
the
session-vars-5-darwin-terminfo
branch
from
November 18, 2026 01:13
b10bf13 to
dda6403
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Builds Darwin's
TERMINFO_DIRSfromhome.sessionSearchVariablesplus the new append option instead of one self-referentialhome.sessionVariablesvalue.On the first merge, Home Manager's terminfo directory comes first and
/usr/share/terminfocomes last. Inherited directories remain between them, and configured entries are not duplicated. Later merges preserve the positions of configured entries already present inTERMINFO_DIRS.Adds
targets.darwin.terminfo.enable. The 2026-04-20 news entry told users to opt out by overridinghome.sessionVariables.TERMINFO_DIRS. That value now composes with the module's paths instead of disabling them, so the new news entry points to the explicit option.Part of splitting #9735 into independently reviewable changes. The stack as a whole supersedes that PR.
Verification
nix build path:.#test-allnix fmt -- --ciChecklist
home.sessionVariables.TERMINFO_DIRSopt-out now composes with the module paths; news entry included.)nix fmt.nix build .#test-all.{component}: {description}format.