Repository navigation
fix(plugins): match show/hide patterns regardless of case - #3812
Merged
nicolargo merged 1 commit intoOct 23, 2026
Merged
Conversation
v4 compiled the show/hide regexes with re.I, so hide=ethernet.* hid "Ethernet 2". The v5 collection filter compiled them case-sensitive, so such a config silently stopped filtering. Only show/hide get the flag: the processlist export filter keeps its v4 case-sensitive match.
Owner
|
Thanks @LuisFigueroaG Merged into develop ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
v4 compiled the
show/hidepatterns withre.I(plugin/model.pyis_show/is_hide), so they matched an item whatever its case. The v5 collection filter compiles them case-sensitive, so a config that worked on v4 now silently filters nothing. This shows up with mixed-case names such as Windows interfaces (Ethernet 2,Wi-Fi), container names or sensor labels:_compile_filter()takes an optionalflagsargument, and onlyshow/hidepassre.IGNORECASE. The[processlist] exportfilter, which uses the same helper, keeps its case-sensitive match like in v4. Matching still usesre.search, and aliases were already matched case-insensitively.Tested with a new parametrized case in
tests/test_plugin_base.py, which fails ondevelop. Test suite and pre-commit pass.Resume