Skip to content

Add chevron icons to task type category selectors - #687

Open
julien-nc wants to merge 1 commit into
mainfrom
enh/681/task-type-category-buttons
Open

julien-nc wants to merge 1 commit into
mainfrom
enh/681/task-type-category-buttons

Conversation

@julien-nc

@julien-nc julien-nc commented Oct 9, 2026 •

Copy link
Copy Markdown
Member

closes #681

This makes it more obvious what is a category and what is not. And what has a sub menu.

Kooha-2026-10-09-17-32-13.webm

This is a bit of a hack. It's not possible to control the rendering of NcAction's menu name (it takes a string in the menu-name prop). The only place with a slot is the icon. So I went for putting everything in the icon slot and fixing the style issues with CSS.

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI (N/A)

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@julien-nc julien-nc added enhancement New feature or request 3. to review design Design, UI, UX, etc. labels Oct 9, 2026
@coderabbitai

coderabbitai Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2da06d61-4cea-434c-b2f5-cc7e6b50faee

📥 Commits

Reviewing files that changed from the base of the PR and between ceef92b and 2c147ba.


📒 Files selected for processing (1)
  • src/components/TaskTypeSelect.vue

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.



📝 Walkthrough

Walkthrough

Inline category menu triggers now display the category label and a chevron in the icon slot. The chevron reflects whether that category’s menu is open. The component tracks the open menu by category ID and clears the state on close only when the closing menu matches the tracked ID. Styles align the trigger content, truncate the label, and hide the menu-name text.


Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 2c147

The menu triggers display category labels and reflect their open state. No actionable merge-blocking risk was identified; normal checks are sufficient.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Title check Passed The title clearly and concisely describes the main change: adding chevron icons to task type category selectors.
Description check Passed The description explains the purpose and implementation of the category selector changes and includes a demonstration video.


  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review design Design, UI, UX, etc. enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Indicate that the submenus in Assistant's modals are submenus instead of buttons

1 participant