Repository navigation
fix MySQLSchemaTool FK introspection under ONLY_FULL_GROUP_BY - #688
Merged
ilvalerione merged 1 commit intoOct 12, 2026
Merged
ilvalerione merged 1 commit into
ilvalerione merged 1 commit into
Conversation
Include ORDINAL_POSITION in SELECT DISTINCT so MySQL/MariaDB accept ORDER BY under strict SQL mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
What does this PR do?
Includes
kcu.ORDINAL_POSITIONin theSELECT DISTINCTlist ofMySQLSchemaTool::getRelationships().Why is this change needed?
MySQL/MariaDB with
ONLY_FULL_GROUP_BYrejectDISTINCT+ORDER BYon columns not in the SELECT list (error 3065), soanalyze_mysql_database_schemacrashes before returning schema.How does this change should be used and documented?
No API/docs changes. Existing
MySQLSchemaToolusage keeps working.Related Issues
Testing
Breaking Changes
Documentation
Checklist