fix(cca, discrim): fix CCA statistics and discrim ordering - #447
Open
ChickenisLegit wants to merge 3 commits into
Open
fix(cca, discrim): fix CCA statistics and discrim ordering#447ChickenisLegit wants to merge 3 commits into
ChickenisLegit wants to merge 3 commits into
Conversation
✅ Deploy Preview for hyppo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
sampan501
requested changes
Aug 23, 2026
sampan501
left a comment
sampan501
left a comment
Collaborator
There was a problem hiding this comment.
Can you verify that these stats are right against a reference implementation? Right now, some of the tests have been loosend.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #413 (CCA Incorrect Statistics) and fixes #422 (DiscrimTwoSample output depends on input order). CCA statistics are now correctly computed as canonical correlation instead of squared singular values. DiscrimTwoSample ordering is fixed by computing isolated values once rather than independently per input.