Repository navigation
Update nyc for the supported Node CI matrix - #229
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #229 +/- ##
==========================================
+ Coverage 95.99% 96.04% +0.05%
==========================================
Files 16 16
Lines 549 556 +7
Branches 116 117 +1
==========================================
+ Hits 527 534 +7
- Misses 9 14 +5
+ Partials 13 8 -5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Approved — Updates the coverage runner to NYC 18 without changing the library’s runtime or API. The regenerated lockfile is consistent with the manifest and supported Node matrix.
Changes behavior: no — The change updates development-only coverage tooling and its lockfile. It leaves the library runtime, scripts, and public API unchanged. First look; there is no earlier behavior verdict to clear.
1 note, no action needed
- Suggestion: Keep the owner approval separate from this review
package-json-from-dist@1.0.1is a new development-only dependency, and the lockfile cannot verify the provenance described in the PR. This code review does not provide the separate task-owner approval the PR description says is needed before merge. (package-lock.json:4948)
This codebase is run by Human0.
Keeps coverage tests compatible with the Node versions CI now tests, without changing the library runtime. NYC 18 removes uuid from the coverage dependency tree.
This replaces #225, whose branch still tests Node 14 and conflicts with the updated lockfile.
Verification
npm install --ignore-scripts— passed.npm ci --ignore-scripts— passed.npm run build— passed (36 files compiled).npm run coverage— passed (201 tests; 98.2% statements, 93.27% branches, 98.29% lines).npm run test:build— passed (100 tests).20 || >=22; the current CI matrix is 22/24/26, so no migration change is needed.Dependency review: NYC adds
package-json-from-dist@1.0.1throughrimraf@6.1.3. The npm registry listsisaacsas publisher of both package-json-from-dist 1.0.0 and 1.0.1 and points togithub.com/isaacs/package-json-from-dist, but neither version has an npm provenance attestation. Its registry manifest has nopreinstall,install, orpostinstallhook; thepreparescript is not run for a registry tarball, and local installs used--ignore-scripts. This dependency needs the task owner\u2019s approval before merge.Task: https://dashboard.human0.ai/tasks/b767de06-c308-4ab4-bb8b-2fc8a36e2f6e
This codebase is run by Human0.