Repository navigation
Bump serialize-javascript and mocha - #222
dependabot[bot] wants to merge 1 commit into
Conversation
dependabot
Bot
added
dependencies
![human0-reviewer[bot]](https://avatars.githubusercontent.com/in/5201148?s=60&v=4){kind=small}
There was a problem hiding this comment.
Changes requested — Updates the test runner to Mocha 12 and resolves serialize-javascript 7.1.4. The current CI matrix cannot run the new Mocha version on Node 14, 16, or 18.
Changes behavior: no — These are dev-dependency changes; the package's own runtime API and promised behavior are unchanged. The failing test jobs are a regression in the existing build/test workflow, not an intentional change to the package promise. First review; there is no prior behavior assessment to clear.
Must fix
- Mocha 12 breaks the supported Node test jobs (
package.json:79)
1 note, no action needed
- Suggestion: Keep the Mocha type declarations aligned
@types/mocharemains at version 10 while the test runner moves to Mocha 12. The current tests use only basicdescribeanditcalls and still type-check, but updating the declarations with the runner would avoid stale types if Mocha 12 changed an API the tests use. (package.json:79)
This codebase is run by Human0.
| "eslint-plugin-prettier": "^4.2.1", | ||
| "husky": "^8.0.2", | ||
| "mocha": "^10.1.0", | ||
| "mocha": "^12.0.3", |
There was a problem hiding this comment.
Must fix: Mocha 12 breaks the supported Node test jobs
The package still tests on Node 14, 16, and 18, but the updated Mocha CLI cannot run on them: the Node 14 job fails parsing Mocha's JSON import attribute, Node 16 reports SyntaxError: Unexpected token 'with', and Node 18 fails with ERR_REQUIRE_ESM. This makes the existing test workflow fail before the suite runs. Keep a Mocha version that supports the current matrix, or update the supported Node versions and CI matrix together.
7e409fe to
d198a45
Compare
There was a problem hiding this comment.
Changes requested — Updates the test-only Mocha dependency and its locked dependency tree. The library's published runtime code and public API are unchanged.
Changes behavior: no — Mocha and its transitive serialize-javascript dependency are development-only; the PR changes test tooling and lockfile entries, not the library's runtime dependencies or API. This is a full look; no prior changes_behavior finding is carried forward.
Must fix
- Mocha 12 can't run in the Node versions CI still tests (
package.json:79)
1 note, no action needed
- Suggestion: Check Mocha's type definitions against version 12
@types/mochastays on 10.x while Mocha moves to 12, and those versions are maintained independently. A type-check against the Mocha APIs this project uses would catch any declaration drift; no incompatibility is evident from this change. (package.json:80)
This codebase is run by Human0.
| "eslint-plugin-prettier": "^4.2.1", | ||
| "husky": "^8.0.2", | ||
| "mocha": "^10.1.0", | ||
| "mocha": "^12.0.3", |
There was a problem hiding this comment.
Must fix: Mocha 12 can't run in the Node versions CI still tests
The workflow still runs the test suite on Node 14, 16, and 18, but Mocha 12.0.3 requires Node 20.19+ or 22.12+. When those jobs install this lockfile and run coverage, Mocha fails to load and all three jobs go red. Keep Mocha on a version that supports the current matrix, or update the supported Node versions and CI together.
Bumps [serialize-javascript](https://github.com/yahoo/serialize-javascript) to 7.1.4 and updates ancestor dependency [mocha](https://github.com/mochajs/mocha). These dependencies need to be updated together. Updates `serialize-javascript` from 6.0.2 to 7.1.4 - [Release notes](https://github.com/yahoo/serialize-javascript/releases) - [Commits](yahoo/serialize-javascript@v6.0.2...v7.1.4) Updates `mocha` from 10.8.2 to 12.0.3 - [Release notes](https://github.com/mochajs/mocha/releases) - [Changelog](https://github.com/mochajs/mocha/blob/main/CHANGELOG.md) - [Commits](mochajs/mocha@v10.8.2...v12.0.3) --- updated-dependencies: - dependency-name: mocha dependency-version: 12.0.3 dependency-type: direct:development - dependency-name: serialize-javascript dependency-version: 7.1.4 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
d198a45 to
95eee99
Compare
There was a problem hiding this comment.
Changes requested — This pull request updates serialize-javascript to 7.1.4 and Mocha to 12.0.3. The Mocha update still breaks the existing Node test jobs.
Changes behavior: no — These are dependency updates; they do not change the project's own API or user-facing promise. The compatibility failure is a regression, not an intended behavior change. The lockfile delta does not remove the incompatibility from the previously reviewed Mocha update.
Must fix
- Mocha 12 still breaks the supported Node test jobs (
package.json:79)
This codebase is run by Human0.
| "eslint-plugin-prettier": "^4.2.1", | ||
| "husky": "^8.0.2", | ||
| "mocha": "^10.1.0", | ||
| "mocha": "^12.0.3", |
There was a problem hiding this comment.
Must fix: Mocha 12 still breaks the supported Node test jobs
Mocha 12.0.3 requires Node 20.19+ or 22.12+, but CI still runs tests on Node 14, 16, and 18. After this merges, those jobs install Mocha 12 and the test command fails before running; keep Mocha on a compatible version or update the CI matrix.
|
Closing this update for now to preserve Node 14, 16, and 18 support. This dependency update requires Node 20. We will leave the alert open and check for a compatible release during the weekly dependency pass. This codebase is run by Human0. |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps serialize-javascript to 7.1.4 and updates ancestor dependency mocha. These dependencies need to be updated together.
Updates
serialize-javascriptfrom 6.0.2 to 7.1.4Release notes
Sourced from serialize-javascript's releases.
... (truncated)
Commits
05c5cebrelease: v7.1.4 (#238)fdb853dFix methods containing nested functions and arrows (#231)f7dfeaedocs: add SECURITY.md pointing to private vulnerability reporting (#237)4d36b82release: v7.1.3 (#236)45e5397fix: ignore functions without mutating input objects (#233)e978a1bfix: serialize Dates with expanded ISO years (#232)2864b3cfix: escape</scriptat the end of a serialized function body (#235)6a73fa1release: v7.1.22bdbaafMerge commit from fork8c8caa7release: v7.1.1Maintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for serialize-javascript since your current version.
Updates
mochafrom 10.8.2 to 12.0.3Release notes
Sourced from mocha's releases.
... (truncated)
Changelog
Sourced from mocha's changelog.
... (truncated)
Commits
51a0cc5chore(main): release 12.0.3 (#6353)1227939fix: support--Xone-char aliases (#6391)bb2e69adocs: refresh help output, fix stale links (#6357)921c161fix: keep watching when the last test file is removed (#6355)3382fddtest: add --import=tsx integration test (#6356)a68344ffix: show require() error on unsupported directory import (#6354)d59467atest: touch a new file without stamping it afterwards (#6349)70db1c7chore(main): release 12.0.2 (#6300)571110ffix: give CLI reporter-option precedence over config file (#6331)a652ff5fix: use find-up-simple to workaround ERR_PACKAGE_PATH_NOT_EXPORTED (#6342)Maintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for mocha since your current version.