Wrap SFTP request identifiers safely - #179
Open
OskarEichler wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: Ruby request IDs can grow without bounds, but SFTP serializes them as unsigned 32-bit values. After wraparound, responses could no longer match their pending request keys.
Fix: Allocate IDs in the wire-format range and skip IDs that are still pending after the counter wraps.
Regression coverage: Adds focused upstream coverage for wraparound and pending-ID avoidance. Protocol base tests: 8 runs / 17 assertions. Full suite: 435 runs / 1,202 assertions with only the pre-existing Ruby 4 StartTest positional-hash/keyword expectation failure.