Preserve numeric create and truncate flags in v5 open requests - #170
Open
OskarEichler wants to merge 1 commit into
Open
Preserve numeric create and truncate flags in v5 open requests#170OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
This was referenced Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Calculate the creation disposition independently of read/write access and encode TRUNCATE_EXISTING when TRUNC is supplied without CREAT.
Reproduction
driver.open(path, IO::WRONLY | IO::TRUNC, {})currently sends OPEN_EXISTING, retaining old contents. Fixed sends TRUNCATE_EXISTING. Read-only CREAT/EXCL flags also retain their requested creation behavior without gaining write-data access.Verification
Breaking changes and limitations
Intentional behavior change: explicitly requested create/truncate flags now take effect, including truncating an existing file when requested. Callers depending on ignored flags must remove those flags. v1-v4 and public signatures are unchanged. No native v5/v6 server was available; verification is packet-level.
No repository tests were added or modified under the contribution's no-new-tests constraint; focused repro/model drivers ran outside the repository. An external verification Gemfile supplies compatible test tools and RDoc without changing upstream tooling. Actual older Ruby/JRuby/Windows compatibility and upstream CI have not been verified. No production or SSH connections, version bumps, release-tool changes or unrelated modernization are included. Git builds are not signed by the upstream gem release key.