Match IO puts value conversion semantics - #164
Open
OskarEichler wants to merge 2 commits into
Open
Conversation
OskarEichler
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: Net::SFTP file puts raised for nil/false values, emitted nothing with no arguments, ignored to_ary conversion, and could recurse forever on recursive arrays.
Fix: Match Ruby IO behavior: emit a newline with no arguments, convert scalar values once, honor to_ary, flatten arrays, preserve empty-array suppression, and terminate recursive arrays with the conventional [...] marker.
Regression coverage: Focused upstream file tests cover nil/false, no arguments, to_ary, nested arrays, empty arrays, and recursive arrays: 35 runs / 114 assertions. Full suite: 436 runs / 1,204 assertions with only the pre-existing Ruby 4 StartTest positional-hash/keyword expectation failure.