Add ICurrentApp to expose the current app id to apps - #1442
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1442 +/- ##
====================================
- Coverage 83% 82% -1%
====================================
Files 201 201
Lines 4162 4165 +3
Branches 485 485
====================================
- Hits 3460 3455 -5
- Misses 497 504 +7
- Partials 205 206 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
1dd0a99 to
68874d2
Compare
helto4real
left a comment
There was a problem hiding this comment.
Thank you for your contribution.
|
@zyga69 can you make sure you have commit that have verified signature, it is a security measure, just fix it and foce push and we are golden. Thank you for your contribution. |
Apps and services resolved in an app's DI scope had no supported way to find out which app they belong to. The only object carrying that information, ApplicationContext, is internal. Add a small read-only ICurrentApp interface exposing the app id, and register the existing scoped ApplicationContext as its implementation. This lets an app inject ICurrentApp (or resolve it from any service in its scope) to select per-app configuration, logging, etc. IApplication is not reused for this because it also exposes lifecycle methods that apps should not call on themselves.
68874d2 to
354443f
Compare
Commit has been signed, thank you for the guidance. |
Breaking change
Proposed change
Apps and services resolved in an app's DI scope had no supported way to find out which app they belong to. The only object carrying that information, ApplicationContext, is internal.
Add a small read-only ICurrentApp interface exposing the app id, and register the existing scoped ApplicationContext as its implementation. This lets an app inject ICurrentApp (or resolve it from any service in its scope) to select per-app configuration, logging, etc. IApplication is not reused for this because it also exposes lifecycle methods that apps should not call on themselves.
Type of change
Additional information
Checklist
If user exposed functionality or configuration are added/changed: