Repository navigation
docs: import types used in decorated signatures with import type - #3679
Merged
kamilmysliwiec merged 1 commit intoOct 30, 2026
Merged
kamilmysliwiec merged 1 commit into
kamilmysliwiec merged 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
Three samples import an Express/Fastify type with a plain
import { ... }and then use it in a decorated signature:fundamentals/provider-scopes.md:constructor(@Inject(REQUEST) private request: Request)in an@Injectable()classhttp/mvc.md(Express):root(@Res() res: Response)on a@Get()handlerhttp/mvc.md(Fastify):root(@Res() res: FastifyReply)on a@Get()handlerThe tsconfig that
nest newgenerates sets bothisolatedModulesandemitDecoratorMetadata. With those options, copying any of these samples into a new project fails to compile:Checked with TypeScript 5.9.3,
@nestjs/common12.3.2,@types/expressandfastify5.12.7, using the compiler options from the schematicstsconfig.json.What is the new behavior?
The three imports use
import type, which is whatcontrollers.md,faq/raw-body.mdandhttp/file-upload.mdalready do for the same types. All three samples compile with those options.The other plain
express/fastifytype imports in the docs (middlewares.md,exception-filters.md,http/performance.mdand theContextIdStrategysample inprovider-scopes.md) don't use the type in a decorated signature, so they compile as they are and I left them alone.Does this PR introduce a breaking change?
Other information