Add ns-download-data mipnerf360 subcommand (S3-compatible)#3768
Draft
goanpeca wants to merge 1 commit into
Draft
Add ns-download-data mipnerf360 subcommand (S3-compatible)#3768goanpeca wants to merge 1 commit into
goanpeca wants to merge 1 commit into
Conversation
Signed-off-by: Gonzalo Peña-Castellanos <goanpeca@gmail.com>
goanpeca
force-pushed
the
b2-mipnerf360-dataset
branch
from
July 1, 2026 14:00
ba18cd1 to
90cd299
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
mipnerf360subcommand tons-download-datathat fetches the Mip-NeRF 360 scenes from an anonymously-readable bucket using the Amazon S3 API. The change is small and additive: no existing download paths are touched, and the new subcommand only appears whenboto3is installed (otherwise it registers asNotInstalled, matching the existing pattern for optional downloaders).Motivation
Mip-NeRF 360 is one of the most common benchmarks people reach for when trying nerfstudio, but there is currently no first-class
ns-download-dataentry for it. This adds one so users can grab the scenes with a single command instead of hunting down the archive by hand.The downloader talks to storage through the standard Amazon S3 API, so it works against any S3-compatible endpoint. It is written to be provider-agnostic: it reads
AWS_S3_ENDPOINT_URL(and accepts--bucket), so the same code path runs against Amazon S3 or any S3-compatible object store (for example Backblaze B2, Cloudflare R2, or MinIO). The endpoint and bucket are plumbing, not baked-in assumptions.What changed
nerfstudio/scripts/downloads/mipnerf360_download.py(new): aMipnerf360Download(DatasetDownload)that lists and downloads scene objects viaboto3over the Amazon S3 API. Anonymous (unsigned) reads by default so no credentials are needed for a public bucket;anonymous=Falsefalls back to standard credentials from the environment. Sets anerfstudio/<version>user-agent fragment on the client.nerfstudio/scripts/downloads/download_data.py: registers themipnerf360subcommand behind aboto3import guard, so users withoutboto3get a clear "install boto3" message rather than an import error.tests/scripts/downloads/test_mipnerf360_download.py(new): unit tests covering endpoint resolution and theAWS_S3_ENDPOINT_URLoverride, the client user-agent and addressing config, signed vs. anonymous request configuration, per-scene pagination/download, and the unknown-scene exit path.boto3calls are mocked, so the tests need no network access..gitignore: allowliststests/scripts/downloads/(thedownloads/ignore rule would otherwise hide the new test files).Apache license headers are on the new files, and the new subcommand's description string is wired through the existing
NotInstalledmechanism.Testing
pytest tests/scripts/downloads/test_mipnerf360_download.pypasses locally. All boto3 interaction is mocked, so no network or credentials are required in CI.ns-dev-testlocally (Ruff format + lint, Pyright, pytest, license headers, docs build) so the PR should land green.Notes
mipnerf360_download.pyare placeholders pending a public mirror being provisioned; happy to update them (or drop the defaults and require--bucketplusAWS_S3_ENDPOINT_URL) based on what you all prefer for hosting.