Move hardcoded quota names from attributes.py to tests - #324
Open
marcoagonzales007 wants to merge 1 commit into
Open
Move hardcoded quota names from attributes.py to tests#324marcoagonzales007 wants to merge 1 commit into
marcoagonzales007 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #298 (Migrated to CCI-MOC/MOC-issues#256) )
This moves the Quota_* constants into a test only module(
tests/attributes.py) and refactors the remaining usesopenstack.pyfinds the Swift object quota by its object instead of by display name.calculate_storage_gb_hoursbills OpenShift storage from each resource's quota specs grouped by invoice_name, like the OpenStack loop already does.register_default_quotasinlines the default display names it registers.convert_swift_quota_to_gibalso had a broken reference to the removedopenstack.QUOTA_KEY_MAPPINGQUOTA_GPUstays in attributes.py because it's still a statically registered allocation attribute used by count_gpu_usage.