Return SPI out of range error from sa_create

[Hashim1999164]

Summary

sa_create treated an out of range SPI as success. The else branch only printed under DEBUG and never set status, so it returned CRYPTO_LIB_SUCCESS even though no SA was created.

This sets CRYPTO_LIB_ERR_SPI_INDEX_OOB on that path, matching the other SA helpers in the same file.

Closes #545

Test plan

• Call SA Create with an SPI >= NUM_SA and confirm the status is CRYPTO_LIB_ERR_SPI_INDEX_OOB
• Confirm a valid SPI create path still returns success

[Hashim1999164]

heads up, i still need to send in the CryptoLib individual CLA pdf to the emails in the readme. will get that over. the code change itself is just the SPI OOB status return

[sylvesterkaczmarek]

This changes a previously silent success into the intended SPI-out-of-range error, but there is no regression test in the PR and the two test-plan boxes are still unchecked. Please add a test that sends spi >= NUM_SA and asserts CRYPTO_LIB_ERR_SPI_INDEX_OOB, plus a valid-SPI case to keep the success path covered.

[Hashim1999164]

@sylvesterkaczmarek fair point. added a unit test in ut_tc_process that hits spi >= NUM_SA for the oob error and a valid spi=1 create for the success path. checkboxes updated too

[Hashim1999164]

yo the CLA for this one is that pdf form in docs/CryptoLib_Indv_CLA.pdf that has to get emailed to gsfc-softwarerequest@mail.nasa.gov with Justin.R.Morris@nasa.gov cc'd. i cant finish that part from here since it needs the signed pdf mailed. code side + the regression test are already on the branch tho

[sylvesterkaczmarek]

Rechecked a283264. sa_create now returns CRYPTO_LIB_ERR_SPI_INDEX_OOB when spi >= NUM_SA, and the new regression exercises that exact boundary plus a valid spi=1 success path. That resolves the missing-test concern I raised.