Validate ARSN security association updates - #543
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
sylvesterkaczmarek wants to merge 1 commit into
sylvesterkaczmarek wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #534.
Fixes #536.
Fixes #537.
Make
sa_setARSNandsa_setARSNWreport rejected updates instead of always returning success, and enforce the missing SA preconditions before mutating anti-replay state.Changes:
CRYPTO_LIB_ERR_SPI_INDEX_OOBSA_NONE) entries before mutationast == 1) before updating ARSN or ARSNWCRYPTO_LIB_SUCCESSCoverage includes out-of-range and uncreated SPIs, encryption-only SAs, valid authentication-capable ARSN/ARSNW updates, and the existing SA 6 cases. The SA 6 tests now expect the service-type error because SA 6 is encryption-only.
Validation:
EP_SA_MGMT.SET_ARSN_REJECTS_UNCREATED_SAEP_SA_MGMT.SET_ARSN_REJECTS_OUT_OF_RANGE_SPIEP_SA_MGMT.SET_ARSNW_REJECTS_NON_AUTHENTICATING_SAEP_SA_MGMT.SET_ARSN_ACCEPTS_AUTHENTICATING_SAEP_SA_MGMT.SET_ARSNW_ACCEPTS_AUTHENTICATING_SAEP_SA_MGMT.SA_6_SET_ARSNEP_SA_MGMT.SA_6_SET_ARSNWgit diff --checkFocused tests were built and passed using CryptoLib's internal key/SA/MC configuration with Homebrew libgcrypt on macOS.