feat(table): cap surfaced row actions at 2 icons once a kebab exists#2191
Open
Fiona2016 wants to merge 5 commits into
Open
feat(table): cap surfaced row actions at 2 icons once a kebab exists#2191Fiona2016 wants to merge 5 commits into
Fiona2016 wants to merge 5 commits into
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Rows with at most 3 actions (and no node/collapsed items) still expand fully. Bigger rows now surface inline items plus non-danger menu items up to 2 icons and collapse the rest - danger items included - into the kebab, which always keeps at least 2 items (icons are demoted back when needed). Default actionMaxIcons drops from 4 to 3.
Fiona2016
changed the title
Decide expand-vs-kebab once per table instead of per row: if any row needs a kebab (too many actions, or node/collapsed items), every row renders in kebab layout, so icons align vertically and the kebab sits in a fixed position. Light rows may then hold a single kebab item - the accepted price of column-aligned consistency, replacing the per-row min-2-kebab-items demotion.
No caller across the three repos ever set it; the expand threshold (3) and surfaced-icon cap (2) are design constants of the row-action rule, not per-table knobs. splitRowActions keeps an internal maxIcons parameter for tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2188 after testing on the 9000 env.
Rule change (2026-07-17)
node/collapseditems) expand fully into icon buttons — no kebab (was: up to 4).node/collapseditems) now surface at most 2 icons:inlineitems stay out, non-dangermenuitems are promoted in order to fill up to 2; everything else — danger items included — collapses into the kebab (menu order preserved, divider before danger).nodeitem sat alone in the kebab.actionMaxIconsdrops from 4 to 3; it now means "full-expansion threshold".Also carries the
RowActions.menusemantics doc commit that missed the #2188 merge window.Verification
splitRowActionsunit tests rewritten for the new rule: 8 cases, 27/27 suite green.tsc --noEmit: 3 errors, all pre-existing Loki/monaco issues untouched by this change (branch baseline was 4).Spec updated in fc-dev-docs (
a22c5c8): table-action-inventory §1, design-system-table §12/§12.1, table-checklist §1, table-migration-playbook.🤖 Generated with Claude Code