Fix KeyError: 'container' when scraping cover photo metadata - #607
Open
mikotokuroko wants to merge 1 commit into
Open
Fix KeyError: 'container' when scraping cover photo metadata#607mikotokuroko wants to merge 1 commit into
mikotokuroko wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ghunt email <address> --json... crashes with aKeyError: 'container'during the person scrape step:This happens in
_scrape()when Google's People API returns cover photo metadata without acontainerfield. The field isn't always present depending on the account's privacy settings / whether a custom cover photo is set, so indexing into it directly with[...]crashes instead of degrading gracefully.Fix
Use
.get()to safely check for thecontainerkey, and skip adding the cover photo entry if it's missing rather than crashing the whole lookup: