DNR Redirects Fail

[karimroshan]

Any DNR redirect I set up simply fails to go anywhere. See screen recordings below.

Screen.Recording.2024-12-23.at.23.19.45.mov

Screen.Recording.2024-12-23.at.23.22.04.mov

[mshibanami]

Hi @karimroshan, I believe that your issue is discussed in #48. Would you please take a look? (Sorry, I forgot to add the DNR label to that issue.)

TL;DR: This should be a bug in Safari, which Redirect Web can't control. As of now, I recommend using the Original type rather than DNR. Sorry for the inconvenience.

[karimroshan]

Hello. Agreed on that one. I will use original for search redirect. Problem is, it also doesn't work for normal links. See screen recording below.
With Original:

Screen.Recording.2024-12-23.at.23.39.37.mov

With DNR:

https://github.com/user-attachments/assets/3223d202-9f43-42ff-ada5-194a359660a4
(it works on a typed link, but NOT a clicked one--loads forever)

Thanks,
Roshan

[mshibanami]

Oh, sorry, I didn't check your second video.
I see. It does look strange. I’ll check it soon.

By the way, it might be worth trying to re-enable the extension from Settings > Extensions or restarting your Mac.

Additionally, I'd like to note that the DNR type is still an experimental feature. It has multiple issues, as mentioned in the documentation, primarily due to Safari’s implementation.

[karimroshan]

Yeah, no worries on this one, just wanted to let you know.

[mshibanami]

Thanks, I've successfully replicated the issue on my end on both iPhone and macOS.

I have submitted feedback to Apple as FB16160560, including a minimal reproducible example as follows:
example.zip

The following code sets a DNR rule for redirecting from Reddit to example.com:

```js
// background.js
(async () => {
    await browser.declarativeNetRequest.updateSessionRules({
        removeRuleIds: [1],
        addRules: [
            {
                id: 1,
                priority: 1,
                action: {
                    type: "redirect",
                    redirect: {
                        url: "https://example.com/",
                    },
                },
                condition: {
                    regexFilter: "https://www.reddit.com/.*",
                    resourceTypes: ["main_frame"],
                },
            },
        ],
    })
    console.log("Background script loaded")
})()
```

Using this rule, I expected a link from Reddit to redirect to example.com. However, in practice, Safari does not transition to example.com.

Please refer to the attached videos (`demo-macos_.mov` and `demo-ios_.mov`) demonstrating the issue on each platform.

Additionally, I have attached a minimal reproducible example to further illustrate the problem. I hope it assists in your investigation.

### Reproduction Steps

1. Download and extract the attached `example.zip`.  
2. Build and run the project using Xcode, then enable the extension in Safari.  
3. Search for "Reddit" on Google.  
4. Click on a link from the search results.

Then:

- Expected Behavior: Following the redirection rule set by the extension, Safari navigates to example.com.
- Actual Behavior: 
  - On macOS: The address bar displays infinite loading, but Safari does not navigate to example.com.  
  - On iOS: Clicking the link has no effect; the browser remains idle.

### Environment

- macOS 15.2 (24C101)
- Safari
    - Technology Preview 210  
    - 18.2
- Xcode 16.2 (16C5032a)

### Context of the Issue

One of the users of my Safari extension, Redirect Web for Safari, reported this issue. I have been able to replicate it as well. You can find the details here:
https://github.com/mshibanami/redirect-web/issues/64