Skip to content

Bug 2056116 - Don't crash sync on an invalid login guid - #7536

Open
jo wants to merge 1 commit into
mozilla:mainfrom
jo:bug-2056116-harden-sync
Open

Bug 2056116 - Don't crash sync on an invalid login guid#7536
jo wants to merge 1 commit into
mozilla:mainfrom
jo:bug-2056116-harden-sync

Conversation

@jo

@jo jo commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Serializing an outgoing record whose guid fails our sync-server sanity check asserted, which took down the parent process. It's now a serde error, and the logins engine skips such a record and reports it as logins-invalid-outgoing-guid, so a single login can't block the whole sync. Incoming records were already handled this way.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

Serializing an outgoing record whose guid fails our sync-server sanity
check asserted, which took down the parent process. It's now a serde
error, and the logins engine skips such a record and reports it as
logins-invalid-outgoing-guid, so a single login can't block the whole
sync. Incoming records were already handled this way.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant