Skip to content

Make text layers easier to drag #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dariomory merged 2 commits into from
Sep 3, 2026
Merged

Make text layers easier to drag #14

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d19c203
Make text layers easier to drag
dariomory Sep 3, 2026
d53574c
Give text layers a forgiving hit box
dariomory Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/canvas/draw-document.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,9 @@ function drawCheckerboard(
}
}

/** Document-space slop around a text layer, so near misses still grab it. */
const TEXT_HIT_PADDING = 6;

export function hitTestLayer(document: Document, docX: number, docY: number): Layer | undefined {
for (let i = document.layers.length - 1; i >= 0; i -= 1) {
const layer = document.layers[i];
Expand All @@ -98,7 +101,15 @@ export function hitTestLayer(document: Document, docX: number, docY: number): La
const scaleY = layer.transform.scaleY;
const width = source.width * scaleX;
const height = source.height * scaleY;
if (docX < x || docY < y || docX > x + width || docY > y + height) continue;
// Text rasters sit tight around the glyphs and are mostly transparent
// between them, so a per-pixel alpha test makes text slip out from under
// the cursor. Text is picked by its whole box, plus a little slop at the
// edges, and that box is what both dragging and click-to-edit use.
const isText = layer.kind === "text" || layer.role === "text";
const pad = isText ? TEXT_HIT_PADDING : 0;
if (docX < x - pad || docY < y - pad || docX > x + width + pad || docY > y + height + pad) continue;
if (isText) return layer;

const localX = (docX - x) / scaleX;
const localY = (docY - y) / scaleY;
if (source instanceof HTMLCanvasElement && sampleCanvasAlpha(source, localX, localY) < 10) {
Expand Down
Loading