[codex] Use moonbit-lsp binary#46
Draft
tonyfettes wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$MOON_HOME/bin/moonbit-lspover the legacy$MOON_HOME/bin/lsp-server.jswhen starting MoonBit LSP.moonbitbuffers that are attached manually, such asmoon.pkg.Root Cause
The Neovim plugin was still probing for the old
lsp-server.jsentrypoint first. Users with a stale executable there could end up connected to the old language server, while the official VS Code extension now startsmoonbit-lsp. When a user's generic LSP format-on-save hook hit that stale server,:wcould fail until LSP was disabled.Validation
env NVIM_LOG_FILE=/private/tmp/moonbit-nvim-tests.log nvim --headless --noplugin -u tests/minimal_init.lua -c "PlenaryBustedDirectory tests/ {minimal_init = 'tests/minimal_init.lua'}"All existing Plenary tests pass, including the new LSP command selection tests.