Skip to content

Add thread_creation_menu_timeout to duration_seconds config group - #3451

Merged
StephenDaDev merged 2 commits into
developmentfrom
users/sebkuip/threadmenu_timeout_fix
Aug 3, 2026
Merged

Add thread_creation_menu_timeout to duration_seconds config group#3451
StephenDaDev merged 2 commits into
developmentfrom
users/sebkuip/threadmenu_timeout_fix

Conversation

@sebkuip

@sebkuip sebkuip commented Jul 20, 2026

Copy link
Copy Markdown
Member

This config value is not validated to be in seconds, but the threadmenu expects seconds. This PR adds this value to the duration_seconds config group such that it is validated, and if possible converted from other formats.
afbeelding

This closes #3449

@StephenDaDev StephenDaDev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested working, resolves bug

@lorenzo132
lorenzo132 self-requested a review August 1, 2026 12:00
@sebkuip sebkuip added bug This is a confirmed bug pending review code improvement staged Staged for next version in progress changelog Changes in PR have been added to draft release that will be used for the changelog on the next ver. and removed in progress labels Aug 1, 2026
@martinbndr
martinbndr self-requested a review August 2, 2026 05:08
@StephenDaDev
StephenDaDev enabled auto-merge (rebase) August 3, 2026 14:48
@StephenDaDev
StephenDaDev merged commit 3ff4261 into development Aug 3, 2026
4 checks passed
@StephenDaDev
StephenDaDev deleted the users/sebkuip/threadmenu_timeout_fix branch August 3, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug This is a confirmed bug changelog Changes in PR have been added to draft release that will be used for the changelog on the next ver. code improvement pending review staged Staged for next version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: the config thread_creation_menu_timeout is not part of the duration_seconds group and thus is not validated to be valid

4 participants