Skip to content

[F-29] fix(network): reject oversized peer list responses in get_ipl() #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adequatelimited merged 1 commit into from
Apr 6, 2026
Merged

[F-29] fix(network): reject oversized peer list responses in get_ipl() #142

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/network.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -748,10 +748,18 @@ int get_ipl(NODE *np, word32 ip)
/* send OP_GET_IPL and receive single packet response */
ecode = send_op(np, OP_GET_IPL);
if (ecode == VEOK) ecode = recv_tx(np, STD_TIMEOUT);
/* reject oversized peer lists (DoS mitigation) */
if (ecode == VEOK
&& get16(np->tx.len) > RPLISTLEN * sizeof(word32)) {
ecode = VEBAD;
}
/* cleanup */
sock_close(np->sd);
np->sd = INVALID_SOCKET;
}
/* TODO: received peer IPs should be treated as unverified candidates
* until confirmed as real nodes, rather than added directly to the
* scan/recent peer lists. See: https://github.com/mochimodev/mochimo/issues/107 */

return ecode;
} /* end get_ipl() */
Expand Down
Loading