Repository navigation
Shorten the subscription modal button and link the Self-hosted card to the guide - #3105
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3105 +/- ##
==========================================
- Coverage 96.20% 96.20% -0.01%
==========================================
Files 673 673
Lines 39755 39749 -6
Branches 11145 11144 -1
==========================================
- Hits 38246 38240 -6
Misses 521 521
Partials 988 988
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
1 issue found across 2 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/frontend/src/pages/Upgrade.tsx">
<violation number="1" location="packages/frontend/src/pages/Upgrade.tsx:158">
P2: Removing the 'Continue without a subscription' button removes the only in-page way back to the dashboard for a free user who opened `/upgrade` in a fresh tab. The Back button is hidden when `window.history.length <= 1`, so this user is left with no dashboard link. Keep a visible route to `/` on this page, for example a 'Dashboard' link or button next to the self-hosted CTA.</violation>
</file>
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
| </button> | ||
| <a | ||
| class="upgrade-plan-card__no-commitment" | ||
| class="btn btn--outline" |
There was a problem hiding this comment.
P2: Removing the 'Continue without a subscription' button removes the only in-page way back to the dashboard for a free user who opened /upgrade in a fresh tab. The Back button is hidden when window.history.length <= 1, so this user is left with no dashboard link. Keep a visible route to / on this page, for example a 'Dashboard' link or button next to the self-hosted CTA.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At packages/frontend/src/pages/Upgrade.tsx, line 158:
<comment>Removing the 'Continue without a subscription' button removes the only in-page way back to the dashboard for a free user who opened `/upgrade` in a fresh tab. The Back button is hidden when `window.history.length <= 1`, so this user is left with no dashboard link. Keep a visible route to `/` on this page, for example a 'Dashboard' link or button next to the self-hosted CTA.</comment>
<file context>
@@ -154,18 +154,8 @@ const Upgrade: Component = () => {
- </button>
<a
- class="upgrade-plan-card__no-commitment"
+ class="btn btn--outline"
href={SELF_HOSTING_GUIDE_URL}
target="_blank"
</file context>
Two fixes on the subscription screens after the Pro-only cutover.