Skip to content

Shorten the subscription modal button and link the Self-hosted card to the guide - #3105

Merged
SebConejo merged 2 commits into
mainfrom
fix/subscribe-button-label
Nov 2, 2026
Merged

SebConejo merged 2 commits into
mainfrom
fix/subscribe-button-label

Conversation

@SebConejo

@SebConejo SebConejo commented Nov 2, 2026 •

Copy link
Copy Markdown
Member

Two fixes on the subscription screens after the Pro-only cutover.

  • The subscription required modal button read "Subscribe for US$19/month" and wrapped on two lines. It now reads "Subscribe"; the price stays in the modal text above it.
  • On the Upgrade page, the Self-hosted card button was "Continue without a subscription" with a "Read the self-hosting guide" link under it. The button is now "Read the self-hosting guide" and opens the guide in a new tab. The Back button at the top of the page already returns to the dashboard.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

View guided diff | Turn on auto-fix | Re-trigger cubic

@SebConejo SebConejo changed the title Shorten the subscription modal button to Subscribe Shorten the subscription modal button and link the Self-hosted card to the guide Nov 2, 2026
@codecov

codecov Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.20%. Comparing base (c45a40d) to head (43c0298).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3105      +/-   ##
==========================================
- Coverage   96.20%   96.20%   -0.01%     
==========================================
  Files         673      673              
  Lines       39755    39749       -6     
  Branches    11145    11144       -1     
==========================================
- Hits        38246    38240       -6     
  Misses        521      521              
  Partials      988      988              
Flag Coverage Δ
backend 95.20% <ø> (ø)
frontend 97.44% <ø> (-0.01%) ⬇️
shared 98.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 2 files (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="packages/frontend/src/pages/Upgrade.tsx">

<violation number="1" location="packages/frontend/src/pages/Upgrade.tsx:158">
P2: Removing the 'Continue without a subscription' button removes the only in-page way back to the dashboard for a free user who opened `/upgrade` in a fresh tab. The Back button is hidden when `window.history.length <= 1`, so this user is left with no dashboard link. Keep a visible route to `/` on this page, for example a 'Dashboard' link or button next to the self-hosted CTA.</violation>
</file>

Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic

</button>
<a
class="upgrade-plan-card__no-commitment"
class="btn btn--outline"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Removing the 'Continue without a subscription' button removes the only in-page way back to the dashboard for a free user who opened /upgrade in a fresh tab. The Back button is hidden when window.history.length <= 1, so this user is left with no dashboard link. Keep a visible route to / on this page, for example a 'Dashboard' link or button next to the self-hosted CTA.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At packages/frontend/src/pages/Upgrade.tsx, line 158:

<comment>Removing the 'Continue without a subscription' button removes the only in-page way back to the dashboard for a free user who opened `/upgrade` in a fresh tab. The Back button is hidden when `window.history.length <= 1`, so this user is left with no dashboard link. Keep a visible route to `/` on this page, for example a 'Dashboard' link or button next to the self-hosted CTA.</comment>

<file context>
@@ -154,18 +154,8 @@ const Upgrade: Component = () => {
-                      </button>
                       <a
-                        class="upgrade-plan-card__no-commitment"
+                        class="btn btn--outline"
                         href={SELF_HOSTING_GUIDE_URL}
                         target="_blank"
</file context>

@SebConejo
SebConejo merged commit b0c81b0 into main Nov 2, 2026
20 checks passed
@SebConejo
SebConejo deleted the fix/subscribe-button-label branch November 2, 2026 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant