Repository navigation
fix: map Gemini blocked finish reasons to content_filter - #3101
Merged
guillaumegay13 merged 1 commit intoNov 2, 2026
Merged
Conversation
Signed-off-by: Alex Castillo <alex.castillog33@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3101 +/- ##
=======================================
Coverage 96.19% 96.19%
=======================================
Files 673 673
Lines 39727 39727
Branches 11084 11084
=======================================
Hits 38217 38217
Misses 521 521
Partials 989 989
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gemini replies that Google blocks with
BLOCKLIST,PROHIBITED_CONTENT,SPIIorIMAGE_SAFETYwere reported to clients as a normalstop.Root cause
mapFinishReasoningoogle-adapter.tsonly mappedSAFETYandRECITATIONtocontent_filter; every other blocking reason fell through to the?? 'stop'default, so clients saw an empty reply that looked like a successful completion (non-streaming and streaming both use this function).Fix
Add the four missing blocking reasons to the map as
content_filter, plus a patch changeset.Test
google-adapter.spec.ts: a parametrised test for the four reasons. It fails (4 failures) before the change and passes after; the whole spec file is green (138 tests).This change was prepared with the assistance of an AI coding agent (Claude).
Summary by cubic
Fixes Gemini replies blocked by Google for
BLOCKLIST,PROHIBITED_CONTENT,SPII, orIMAGE_SAFETYbeing reported to clients as a normalstopinstead ofcontent_filter.mapFinishReasoningoogle-adapter.tsso both streaming and non-streaming responses report them ascontent_filter.manifest.Written for commit 75544d3. Summary will update on new commits.