docs: remove references to removed --no-verify-script launch flag - #3959
Open
latent-9 wants to merge 1 commit into
Open
docs: remove references to removed --no-verify-script launch flag#3959latent-9 wants to merge 1 commit into
latent-9 wants to merge 1 commit into
Conversation
The distributed launch guide documents a --no-verify-script flag for mlx.launch, but that flag (and its script-verification logic) was removed from python/mlx/_distributed_utils/launch.py. As written, the example command passes --no-verify-script through parse_known_args and mlx.launch treats it as the program to run instead of ./my-job.sh. Drop the flag from the example and remove the paragraph describing the no-longer-existent feature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The distributed-launch guide documents a
--no-verify-scriptflag formlx.launch, but that flag was removed from the launcher.python/mlx/_distributed_utils/launch.py(themlx.launchentry point) defines no--no-verify-scriptoption and contains no script-verification logic — grep forverifythere returns nothing. The flag and its logic were removed in the launcher cleanup (PR #3513); this doc page was last edited before that and went stale.Because
launch.pyusesparse_known_args(), the documented command does not error cleanly —--no-verify-scriptfalls into the leftover args, and since it is not--, the launcher treats--no-verify-scriptas the program to run instead of./my-job.sh, so the job does not run as documented.This removes the flag from the example command and deletes the paragraph describing the no-longer-existent feature. Docs-only, no functional change.