Skip to content

[COMMENT] AdamW including bias + Clip grad norm closer to pytorch performances #1623

Closed

Description

@thegodone

Comment:

Using the AdamW with bias correction (not the one in mlx) combine with clip_grad_norm allows to be similar to pytorch performances.

One possible explanation is that pytorch also has a trick to avoid gradient explosion.

Another one explanation, more logical, is that the initialisation has a big impact on gradient stability.

The fact that the LR changes at each iteration instead of each epoch can be the last one.

Suggestion feature : Having LR scheduler with a option to do it per batch or per epoch would be a great feature to evaluate.

Here a view of 10 time runs using the same initialization (loading identical saved weights for each run) & same data split (mv = validation, mt = test)

image
.
we can see the real deviation of RMSE over the runs.

Desktop (please complete the following information):

  • OS Version: [e.g. MacOS 15.1.1]
  • Version [e.g. 0.21.0]

Activity

  1. changed the title [-][COMMENT] AdamW including bias + Clip grad norm closer to pytorch results[/-] [+][COMMENT] AdamW including bias + Clip grad norm closer to pytorch performances[/+] on Nov 25, 2024
  2. locked and limited conversation to collaborators on Apr 14, 2026
  3. converted this issue into a discussion #3411 on Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions