Repository navigation
feat: Add config option to allow non unique warp names - #133
Open
bwachtendorf wants to merge 1 commit into
Open
bwachtendorf wants to merge 1 commit into
bwachtendorf wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 Summary
Currently you are not allowed to create a warp if there already is a warp with that name.
This is fine for single world servers, but on multi-world servers you quickly run into the problem that you have to add suffixes to every warp name.
I could not find any use of warps name besides the duplicate name check and during my testing didn't experience any issues.
🔗 Linked Issues
n/a
Don't think so
📸 Screenshots/Video (if applicable)
n/a
🏁 Quality Check
By submitting this PR, I agree to license my contributions under the project's current license.