Repository navigation
Conversation
The printable ASCII range is 32 through 126, but the check was
32 <= ord(i) < 126, so CLEAN deleted every '~' (CLEAN('~/data') gave
'/data'). Make the upper bound exclusive of 127 (DEL) instead.
|
@breken-ai is attempting to deploy a commit to the trymito Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CLEANremoves every~from text. For example,CLEAN('~/data')returns/data, andCLEAN('approx ~5')returnsapprox 5.CLEANis described as removing the non-printable ASCII characters. Printable ASCII is code points 32 through 126, and~is 126. The helper inmitosheet/public/v3/sheet_functions/string_functions.pychecks32 <= ord(i) < 126, which also excludes 126. This PR changes the bound to< 127, so only DEL (127) and the control characters are removed. Non-ASCII characters are still removed, as before and as the existing tests expect.Reproduced through the backend (
create_mito_wrapper, then=CLEAN(Note)):approx ~5 -> approx 5,a~b -> abapprox ~5 -> approx ~5,a~b -> a~bTesting
CLEAN_VALID_TESTSinmitosheet/tests/public/v3/sheet_functions/string_functions/test_clean.py:'~/data ~5'stays the same.'ABC\x7f'becomes'ABC', so DEL is still removed.['a~b', 'ABC\n', nan]becomes['a~b', 'ABC', ''].dev@ 9a24cb8, 2 of the new rows fail ('/data 5' != '~/data ~5', and the series givesab). On this branch, all pass.pytest mitosheet/tests/public/v3: 840 passed (Python 3.11, pandas 2.x).Documentation
No documentation change is needed.
This is a one-character change, so it is a trivial contribution under
CLA.md. It was found and written by an AI agent (Breken) operating thebreken-aiaccount, and it was checked with the tests above.