feat(cloud): honor ANTON_CLOUD_ARTIFACTS_ROOT as the artifacts dir (ENG-2056) - #414
Open
torrmal wants to merge 1 commit into
Open
feat(cloud): honor ANTON_CLOUD_ARTIFACTS_ROOT as the artifacts dir (ENG-2056)#414torrmal wants to merge 1 commit into
torrmal wants to merge 1 commit into
Conversation
…NG-2056) The cloud workspace mount is per-conversation, so the derived <workspace>/.anton/artifacts only ever showed a task its own artifacts. scratchpad-controller now mounts the PROJECT-level artifacts dir as a second mount outside the workspace (so it can't land on sys.path) and sets this env var to say where; when present, it replaces the derived default so sibling tasks in one project share a single artifacts tree. resolve_trusted_artifacts_root mirrors resolve_trusted_workspace_path's validation exactly (same trust posture — both are pod-side controller config, never wire data): absolute, no '..', canonicalise, create. Unset env var — desktop, CI, older controllers — leaves today's derivation byte-identical (resolve_workspace already only derives artifacts_dir when relative, so pre-setting an absolute path is the narrowest change). Pairs with mindsdb/scratchpad-controller (the mount) and mindsdb/cowork-server (project-level artifact roots).
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part 2/3 of ENG-2056. The cloud workspace mount is per-conversation, so the derived
<workspace>/.anton/artifactsonly ever showed a task its own artifacts. scratchpad-controller (mindsdb/scratchpad-controller#35) now mounts the PROJECT-level artifacts dir as a second mount outside the workspace and announces it viaANTON_CLOUD_ARTIFACTS_ROOT; when set, anton uses it asartifacts_dir, so sibling tasks in one project share a single artifacts tree.resolve_trusted_artifacts_root()mirrorsresolve_trusted_workspace_path()'s validation exactly (same trust posture — both are pod-side controller config, never wire data): absolute, no.., canonicalise, mkdir, is-dir.settings.artifacts_dirbeforeresolve_workspace, which already leaves an absolute value alone — the narrowest possible change.Workspace.artifacts_dirand the cloud artifact tools follow automatically (pathlib/with an absolute right operand).Pairs with mindsdb/cowork-server#404 (project-level artifact roots + pre-enqueue mkdir).
Test plan
uv run --group dev pytest tests/ --ignore=tests/e2e) — 2723 passed, 31 skipped (pre-existing)..rejected)🤖 Generated with Claude Code