Skip to content

build(packaging): bundle internal data assets and config - #93

Merged
mikeqfu merged 1 commit into
masterfrom
fix/package-data
Aug 25, 2026
Merged

mikeqfu merged 1 commit into
masterfrom
fix/package-data

Conversation

@mikeqfu

@mikeqfu mikeqfu commented Aug 25, 2026

Copy link
Copy Markdown
Owner

Summary

Resolves a packaging issue where internal non-Python data assets residing in pyrcs/data/ (e.g. catalogue, introduction, line-data and other assets) were excluded from built wheel and source distribution archives.

Key Changes

Recursive asset inclusion: Added artifacts pattern pyrcs/data/**/* under [tool.hatch.build] in pyproject.toml to guarantee all nested data subdirectories are bundled regardless of VCS tracking status.

Verification

Built distribution artifacts via uv and confirmed inclusion using archive inspection:

python -m zipfile -l dist/pyrcs-1.2.0-py3-none-any.whl | grep -E "pyrcs/(data|pyproject.toml)"

and

tar -tzf dist/pyrcs-1.2.0.tar.gz | grep -E "pyrcs/(data|pyproject.toml)"

@mikeqfu mikeqfu self-assigned this Aug 25, 2026
@mikeqfu mikeqfu added bug Something isn't working packaging Changes related to Python packaging, distribution, or build configuration. labels Aug 25, 2026
@codecov

codecov Bot commented Aug 25, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.89%. Comparing base (d08e905) to head (76c87e6).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #93   +/-   ##
=======================================
  Coverage   84.89%   84.89%           
=======================================
  Files          25       25           
  Lines        3629     3629           
  Branches      662      662           
=======================================
  Hits         3081     3081           
  Misses        313      313           
  Partials      235      235           
Flag Coverage Δ
py3.12 84.89% <ø> (ø)
py3.13 84.89% <ø> (ø)
py3.14 84.89% <ø> (ø)
py3.15 84.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mikeqfu
mikeqfu merged commit 472f6bb into master Aug 25, 2026
9 checks passed
@mikeqfu
mikeqfu deleted the fix/package-data branch August 25, 2026 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working packaging Changes related to Python packaging, distribution, or build configuration.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant