Repository navigation
Consolidate trailing CancellationToken detection - #12021
Merged
Amaury Levé (Evangelink) merged 2 commits intoOct 19, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.
1 of 7 tasks
Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.
Copilot
AI
changed the title
[WIP] Refactor duplicated trailing CancellationToken detection logic
Consolidate trailing CancellationToken detection
Oct 19, 2026
Amaury Levé (Evangelink)
marked this pull request as ready for review
October 19, 2026 18:47
Amaury Levé (Evangelink)
deleted the
copilot/duplicate-code-resolution
branch
October 19, 2026 18:47
Amaury Levé (Evangelink)
added a commit
that referenced
this pull request
Oct 20, 2026
Resolve the conflict with #12021 by retaining its shared display-name predicate and removing the now-redundant private duplicate. Keep the tuple-row helper extraction without changing its expression or evaluation order. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: ba332d0f-f512-4fa7-80b6-9731c87a2c96
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trailing
CancellationTokendetection and explicit-token row checks were duplicated across TestFramework and PlatformServices, risking inconsistent behavior. This change centralizes both rules while preserving the combinatorial value-provider opt-out.TestDataSourceUtilities; use them in combinatorial generation, display-name formatting, and the adapter.