Test server control channel guard conditions by Copilot · Pull Request #12006 · microsoft/testfx

Copilot · 2026-10-18T19:58:40Z

StartServerControlChannelAsync had direct coverage for HTTP transport, but not the named-pipe capability, pipe-name, and idempotency guards.

Coverage: Add tests for an empty pipe name despite negotiated support, a pipe name without negotiated capability, and a previously installed client/listener.
Assertions: Verify the callback is not invoked and control-channel state remains null or unchanged. The existing-client sentinel uses the production assembly’s embedded client type.

Fixes [test-improver] Add unit tests for DotnetTestConnection.StartServerControlChannelAsync guard conditions #11998

Copilot

Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.

Copilot-Session: ac39bde3-795f-4dec-ba78-a68f3a985bc5

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: a005d953-ad6b-4b3d-b49c-ff9d08535ade

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 108604f3-17ca-43af-8195-82650df14d98 Copilot-Session: 36ed0c4f-9841-4072-9089-a18481a7238a

…11978) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 7f8d16f6-c5ed-4e1d-a9d7-fbd59038cd8c

Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>

Copilot

🟢 Approval recommended

The focused, test-only additions cover the intended guards with no unresolved blocking findings.

No open issues 🎉

_{Review effort: Balanced}

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>

) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com> Co-authored-by: Amaury Levé <amauryleve@microsoft.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: dab0e603-7c32-4f24-9419-9346f72f2380

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Copilot-Session: e91db52f-30be-43f0-bd01-b8069a1068e7

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com> Co-authored-by: Amaury Levé <amauryleve@microsoft.com> Copilot-Session: 7d66cb13-77ee-4a7f-95a2-095636a874e6

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 2ddcd011-e1d0-4f3f-bcd1-f83ae14ca4a5 Copilot-Session: 084f77f0-4cc0-4b70-88d5-97938d5471a0

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…tection (#12019) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…er (#11993) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: ee33a395-fd34-4ee5-8e07-4fb1b3339a0d

Preserve both sets of server control channel guard tests and the shared test helpers. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 261b8c54-d4eb-41f7-954d-9e6e54b766a3

Copilot

🔵 Needs a closer look

Cross-product execution and launcher changes require focused human review and revision-matched validation beyond the reported guard tests.

1 open issue

PR scope exceeds described control-channel test changes · New

_{Review effort: Balanced}

                    // In case of WinUI's default synchronization context, this will ensure that the test method runs on the UI thread.
                    if (await RunTestInitializeMethodAsync(classInstance, result, timeoutTokenSource).ConfigureAwait(true))
                    {
+                        arguments = GetArgumentsWithCancellationToken(arguments);


Initial plan

4c577ac

Copilot AI self-assigned this Oct 18, 2026

Copilot AI balanced review requested due to automatic review settings October 18, 2026 19:58

Copilot AI assigned Amaury Levé (Evangelink) Oct 18, 2026

Copilot AI reviewed Oct 18, 2026

View reviewed changes

Copilot AI linked an issue Oct 18, 2026 that may be closed by this pull request

[test-improver] Add unit tests for DotnetTestConnection.StartServerControlChannelAsync guard conditions #11998

Closed

Copilot started work on behalf of Amaury Levé (Evangelink) October 18, 2026 19:58

View session

Sergio Pedri (Sergio0694) and others added 6 commits October 18, 2026 22:05

Fix Native AOT DataRow tests with array Type arguments (#11999)

0de5ea7

Copilot-Session: ac39bde3-795f-4dec-ba78-a68f3a985bc5

Split Azure DevOps summary reporter into focused partials (#12002)

a1c7323

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>

Update Aspire acceptance test dependencies (#12004)

ffce5bc

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: a005d953-ad6b-4b3d-b49c-ff9d08535ade

Keep timed MSTest UI tests on their WinUI dispatcher (#11983)

4c01fc1

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 108604f3-17ca-43af-8195-82650df14d98 Copilot-Session: 36ed0c4f-9841-4072-9089-a18481a7238a

Reduce always-loaded MSBuild skill context without losing guidance (#…

21d2cb2

…11978) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 7f8d16f6-c5ed-4e1d-a9d7-fbd59038cd8c

Add guard-condition tests for server control channel

7d020c0

Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>

Copilot AI balanced review requested due to automatic review settings October 18, 2026 20:15

Copilot started reviewing on behalf of Amaury Levé (Evangelink) October 18, 2026 20:16

View session

Copilot AI changed the title ~~[WIP] Add unit tests for guard conditions in StartServerControlChannelAsync~~ Test server control channel guard conditions Oct 18, 2026

Copilot finished work on behalf of Amaury Levé (Evangelink) October 18, 2026 20:18

Copilot AI requested a review from Amaury Levé (Evangelink) October 18, 2026 20:18

Copilot AI reviewed Oct 18, 2026

View reviewed changes

Copilot AI and others added 3 commits October 18, 2026 22:40

Add tests for server control channel startup guards (#12008)

2570ca8

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>

Share GitHub Actions summary markdown helpers (#12003)

2b86e14

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Evangelink <11340282+Evangelink@users.noreply.github.com>

nohwnd-bot mentioned this pull request Oct 18, 2026

[test-improver] Add unit tests for CiRunSummaryModuleIdentity.HasDuplicateModuleIdentity #12010

Closed

github-actions Bot mentioned this pull request Oct 18, 2026

[test-improver] Monthly Activity 2026-10 #11698

Open

3 tasks

Copilot AI mentioned this pull request Oct 19, 2026

Add unit tests for CI summary module identity #12022

Merged

Copilot AI and others added 4 commits October 19, 2026 20:08

Update Aspire test dependencies and Windows CI budget (#11984)

72cb203

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 2ddcd011-e1d0-4f3f-bcd1-f83ae14ca4a5 Copilot-Session: 084f77f0-4cc0-4b70-88d5-97938d5471a0

[main] Update dependencies from devdiv/DevDiv/vs-code-coverage (#12016)

d25ab5d

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

[docs] Update glossary - weekly full scan (#12018)

a2ae2c4

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Amaury Levé (Evangelink) and others added 2 commits October 19, 2026 20:20

[efficiency-improver] Memoize CI summary module-identity duplicate de…

4038b29

…tection (#12019) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Fix packaged MTP discovery and execution in Visual Studio Test Explor…

a7d7711

…er (#11993) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: ee33a395-fd34-4ee5-8e07-4fb1b3339a0d

Amaury Levé (Evangelink) marked this pull request as ready for review October 19, 2026 18:25

github-actions Bot added the needs/merge-conflict-resolution PR has merge conflicts that must be resolved. label Oct 19, 2026

Resolve PR #12006 merge conflicts with main

9a33c42

Preserve both sets of server control channel guard tests and the shared test helpers. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 261b8c54-d4eb-41f7-954d-9e6e54b766a3

Copilot AI balanced review requested due to automatic review settings October 19, 2026 18:39

github-actions Bot added state/needs-review Awaiting review from the team. and removed needs/merge-conflict-resolution PR has merge conflicts that must be resolved. labels Oct 19, 2026

Copilot started reviewing on behalf of Amaury Levé (Evangelink) October 19, 2026 18:40

View session

Amaury Levé (Evangelink) merged commit ea83725 into main Oct 19, 2026
16 of 18 checks passed

Amaury Levé (Evangelink) deleted the copilot/test-improver-add-unit-tests-for-dotnet-test-conne branch October 19, 2026 18:41

github-actions Bot removed the state/needs-review Awaiting review from the team. label Oct 19, 2026

Copilot AI reviewed Oct 19, 2026

View reviewed changes

microsoft-github-policy-service Bot added the state/needs-review Awaiting review from the team. label Oct 19, 2026

Navigation Menu

Repository navigation

Test server control channel guard conditions - #12006

Test server control channel guard conditions#12006
Amaury Levé (Evangelink) merged 18 commits into
mainfrom
copilot/test-improver-add-unit-tests-for-dotnet-test-conne

Copilot AI commented Oct 18, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

Copilot AI commented Oct 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Copilot AI commented Oct 18, 2026 •

edited

Loading