Skip to content

fix(codegen): use REACT_NATIVE constant for npmPackageName#2956

Open
tvinhas wants to merge 1 commit into
microsoft:0.83-mergefrom
tvinhas:fix-codegen-npm-package-name-constant
Open

fix(codegen): use REACT_NATIVE constant for npmPackageName#2956
tvinhas wants to merge 1 commit into
microsoft:0.83-mergefrom
tvinhas:fix-codegen-npm-package-name-constant

Conversation

@tvinhas

@tvinhas tvinhas commented May 13, 2026

Copy link
Copy Markdown

Summary

Replaces the hardcoded 'react-native-macos' string at packages/react-native/react-native.config.js:188 with the REACT_NATIVE constant from scripts/codegen/generate-artifacts-executor/constants.js. The constant already reads
packageJson.name so the resolved value is unchanged on this fork, but the indirection means future package-name moves (workspace renames, internal rebrand, etc.) don't require remembering this one site.

Closes the "Codegen package name constant" item on the Road to 0.83 tracking issue (#2901).

Test Plan

  • pod install in packages/rn-tester runs the codegen step end-to-end and resolves npmPackageName without errors (validated locally on 0.83-merge).
  • No behavior change for the current package name react-native-macos.

@tvinhas tvinhas requested a review from a team as a code owner May 13, 2026 19:31
@tvinhas tvinhas mentioned this pull request May 13, 2026
10 tasks
christopherwxyz added a commit to officialunofficial/react-native-macos that referenced this pull request Jun 6, 2026
…crosoft#2957 microsoft#2959 microsoft#2963 microsoft#2964)

Finishes the 0.83 stabilization on uno/desktop-0.85: codegen npmPackageName
constant, hermes-utils static_h/main branch selection by RCT_HERMES_V1_ENABLED,
three Fabric focus regressions (blur/sendAccessibilityEvent/VirtualView),
React-RCTUIKit.podspec in package files, TouchableBounce focusable +
AccessibilityInfo guards. RNTester-macOS unit tests remain green.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants