fix(l10n-maven-plugin,libidn,libsvm): use JDK 25 - #18267
Conversation
There was a problem hiding this comment.
🟢 Ready to approve
The dependency migrations, generated specs, locks, and validation are consistent; the remaining overlay-organization comment is non-blocking.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
Backports Fedora’s OpenJDK 25 dependency migrations to restore Stage 2 builds.
Changes:
- Selects OpenJDK 25 Java packaging providers.
- Adds documented component overlays and refreshes locks.
- Re-renders affected RPM specs and release metadata.
File summaries
| File | Description |
|---|---|
base/comps/components.toml |
Moves customized components to dedicated definitions. |
base/comps/l10n-maven-plugin/l10n-maven-plugin.comp.toml |
Adds Maven provider overlay. |
base/comps/libidn/libidn.comp.toml |
Adds Java packaging provider overlay. |
base/comps/libsvm/libsvm.comp.toml |
Adds JDK and Maven provider overlays. |
locks/l10n-maven-plugin.lock |
Refreshes input fingerprint. |
locks/libidn.lock |
Refreshes input fingerprint. |
locks/libsvm.lock |
Refreshes input fingerprint. |
specs/l/l10n-maven-plugin/l10n-maven-plugin.spec |
Uses the JDK 25 Maven provider. |
specs/l/libidn/libidn.spec |
Uses the JDK 25 packaging provider. |
specs/l/libsvm/libsvm.spec |
Builds Java artifacts with JDK 25. |
Review details
- Files reviewed: 7/10 changed files
- Comments generated: 1
- Review effort level: Medium
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
0838d6d to
b49b500
Compare
There was a problem hiding this comment.
🟢 Ready to approve
The overlays are scoped, documented, reflected consistently in locks and rendered specs, and supported by the reported build and smoke-test validation.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Review details
- Files reviewed: 8/11 changed files
- Comments generated: 0 new
- Review effort level: Medium
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
javapackages-tools no longer exposes the generic maven-local and javapackages-local capabilities after dropping OpenJDK 21 support. Backport Fedora's consumer migrations to the explicit OpenJDK 25 providers and build libsvm's Java interface with java-25-devel, restoring Stage 2 dependency resolution without reintroducing generic provides. Signed-off-by: Mitch Zhu <mitchzhu@microsoft.com>
b49b500 to
cfb7267
Compare
|
/azp run |
|
Azure Pipelines: 3 pipeline(s) were filtered out due to trigger conditions. |
There was a problem hiding this comment.
🟢 Ready to approve
The overlays are correctly scoped, generated state is synchronized, and the stated build and smoke-test validation covers the changes.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Review details
- Files reviewed: 8/11 changed files
- Comments generated: 0 new
- Review effort level: Balanced
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
|
/azp run |
|
Azure Pipelines: 3 pipeline(s) were filtered out due to trigger conditions. |
Backports Fedora's OpenJDK 25 consumer migrations for
l10n-maven-plugin,libidn, andlibsvmafterjavapackages-toolsstopped exposing the genericmaven-localandjavapackages-localcapabilities.This restores Stage 2 build dependency resolution without reintroducing generic provider aliases.
Changes:
maven-localwithmaven-local-openjdk25inl10n-maven-plugin.javapackages-localwithjavapackages-local-openjdk25inlibidn.libsvm's Java interface withjava-25-develandmaven-local-openjdk25.Validation:
idnexecuted successfully, all three JARs passed integrity checks, and the expected Maven plugin descriptor and Java classes were present.