atftp: fix and enable the %check test suite - #18249
Draft
kgodara912 wants to merge 1 commit into
Draft
Conversation
kgodara912
commented
Jul 29, 2026
kgodara912
commented
- Build atftpd with PCRE support (BuildRequires: pcre2-devel) so the server --pcre option exists; without it the test suite could not start the server.
- Fix test.sh setup: replace the stale unbound $DIRECTORY variable (which aborted test.sh under 'set -u') with chmods that give the privilege-dropping atftpd access to the server root ($TDIR) and a writable log ($SERVER_LOG); its post-drop log reopen otherwise reverts to syslog and breaks the PCRE test.
- Dump test-suite.log on failure for diagnosability.
- Bump release to 2.
- Build atftpd with PCRE support (BuildRequires: pcre2-devel) so the server --pcre option exists; without it the test suite could not start the server. - Fix test.sh setup: replace the stale unbound $DIRECTORY variable (which aborted test.sh under 'set -u') with chmods that give the privilege-dropping atftpd access to the server root ($TDIR) and a writable log ($SERVER_LOG); its post-drop log reopen otherwise reverts to syslog and breaks the PCRE test. - Dump test-suite.log on failure for diagnosability. - Bump release to 2.
microsoft-github-policy-service
Bot
added
Packaging
3.0-dev
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.