[Medium] Patch Tar for CVE-2025-45582. - #18248
Open
AkarshHCL wants to merge 3 commits into
Open
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
AkarshHCL
marked this pull request as draft
July 29, 2026 11:13
Author
v-aaditya
reviewed
Jul 30, 2026
| %build | ||
| FORCE_UNSAFE_CONFIGURE=1 ./configure \ | ||
| export FORCE_UNSAFE_CONFIGURE=1 | ||
| ./configure \ |
|
Peer-review -
Final verdict - Changes LGTM. PR can be opened for FTE review. |
AkarshHCL
marked this pull request as ready for review
July 30, 2026 06:27
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Kanishk-Bansal
approved these changes
Jul 30, 2026
Kanishk-Bansal
left a comment
There was a problem hiding this comment.
Patch Analysis (consumed the ubuntu patch, security fix logic LGTM)
- Buddy Build
- patch applied during the build (check
rpm.log) - patch include an upstream reference
- PR has security tag
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
tarforCVE-2025-45582.Ubuntu 26.04 LTS resolute and modified to work with the current Azure Linux version of tar.
Reference: https://ubuntu.com/security/CVE-2025-45582
3.Squashed backport of the GNU tar openat2 extraction-jail commit series plus the supporting gnulib openat2 module, imported from Ubuntu tar_1.35+dfsg-4ubuntu0.2 (debian/patches CVE-2025-45582-1..10 and -gnulib-1..6). The out-of-scope extrac26.at test registration (from CVE-2026-5704, not applied here) was dropped so patches 9 and 10 apply on tar 1.35.
-This PR also includes two follow-up changes to the same
tarspec:Adding export in line-'export FORCE_UNSAFE_CONFIGURE=1 ' due to reason-
Our CVE fix changes some of tar's build-setup files (aclocal.m4, m4/*.m4, gnu/Makefile.am). Because of that, when make runs, it notices the build scripts changed and re-runs ./configure by itself, a second time.
The build happens as the root user, and tar refuses to run ./configure as root unless FORCE_UNSAFE_CONFIGURE=1 is set. The old spec set this variable only for the first, hand-written configure call — so the second call (the one make starts automatically) didn't have it and the build failed.
Using export makes the variable available to every command in the build step, including that automatic second configure. So both runs pass the check and the build succeeds.
This wasn't needed before because the earlier patches only touched test files, which never cause configure to re-run.
Change Log
SPECS/tar/CVE-2025-45582.patchSPECS/tar/tar.specDoes this affect the toolchain?
NO
Links to CVEs
Test Methodology
RUN_CHECK=y.