feat(fwupd-efi): add AZL SBAT line, keep upstream provenance - #18227
Merged
Conversation
Add a fwupd-efi.azurelinux SBAT entry to fwupdx64/fwupdaa64.efi so the binary is identifiable in a Secure Boot revocation, as required for shim-review submission (AB#20493). fwupd-efi generates its SBAT section at build time via efi/generate_sbat.py, which emits exactly one distro line from the meson -Defi_sbat_distro_* options. Retarget that single slot to azurelinux so the sanctioned generator emits the critical vendor line, then re-inject the upstream Fedora provenance line via objcopy in %install (before %pesign, so the signature covers the final .sbat).
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Azure Linux SBAT identity to fwupd-efi while preserving Fedora provenance before signing.
Changes:
- Adds SBAT configuration and provenance overlays.
- Regenerates the spec and refreshes the component lock.
- Moves the customized component into a dedicated definition.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
base/comps/fwupd-efi/fwupd-efi.comp.toml |
Defines SBAT overlays. |
base/comps/components.toml |
Removes the former inline entry. |
specs/f/fwupd-efi/fwupd-efi.spec |
Contains rendered SBAT and signing changes. |
locks/fwupd-efi.lock |
Refreshes the input fingerprint. |
Contributor
Author
|
/azp run |
|
Azure Pipelines: 3 pipeline(s) were filtered out due to trigger conditions. |
tobiasb-ms
approved these changes
Jul 28, 2026
christopherco
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Azure Linux SBAT identity metadata to the
fwupd-efibinaries for proper SBAT-based revocation (AB#20493).fwupd-efigenerates only one downstream SBAT record through its Meson configuration. This change retargets that generated record from Fedora to Azure Linux, then inserts the original Fedora record back into.sbatbefore%pesignruns.The Azure Linux record provides the distributor-owned SBAT identity needed for future revocation handling, while the Fedora record retains upstream provenance.
Implementation notes
The Fedora provenance EVR is temporarily pinned to
1.8-1.fc43. Azure Linux 4.0 is still pinned to an azldev version without the upstream-EVR macros from azure-linux-dev-tools#290. Replace this local macro with%fedora_upstream_version/%fedora_upstream_releaseonce that work is available in 4.0.Validation
.sbatsection fromfwupdx64.efi: