Repository navigation
[symbolmap] Record Session.Count and skills caching mappings; add ChatHistoryMemoryProvider assessments - #1308
Merged
Quim Muntal (qmuntal) merged 2 commits intoOct 20, 2026
Conversation
…ryProvider assessments Review API-report-driven changes and recent Go commits against the .NET baseline (agent-framework@6a0773b) for the week's audit: - Microsoft.Agents.AI.Abstractions.AgentSessionStateBag.Count: now mapped to the newly added agent.Session.Count() (agent/session.go). - Microsoft.Agents.AI.Skills.Decorators.CachingAgentSkillsSourceOptions and its CacheIsolationKeySelector/RefreshInterval properties, plus AgentSkillsProviderBuilder.UseCachingOptions: assessed as adapted against the newly added agent/skills.ContextProviderOptions.CacheIsolationKeySelector and .RefreshInterval fields (agent/skills/provider.go), replacing the stale "no built-in" note. - Microsoft.Agents.AI.Memory.ChatHistoryMemoryProvider, its nested State type, ChatHistoryMemoryProviderOptions (and SearchBehavior enum), and ChatHistoryMemoryProviderScope: newly assessed against the agent/memory package added by #1092 (agent/memory/provider.go), confirmed against pinned .NET source at the baseline commit. Verified against agent-framework-go API report (d246604..29b3a1a), reconcile.json, and pinned .NET source at commit 6a0773ba2180e8036d138dbb9794ae64ec2d978b. New embedding-generator exports (foundryprovider/openaiprovider/otelprovider) and CosmosDB vector-store additions remain outside the catalog's inventoried .NET assemblies (Microsoft.Extensions.AI, Microsoft.Agents.AI.CosmosNoSql) and are not addressed here. Internal-only changes (toolapproval, a2a, harness bugfixes) carried no exported API changes. Validation: go -C _catalog run ./cmd/symbolmap reconcile -summary -check; git diff --check. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
github-actions
Bot
added
the
size:large
This comment has been minimized.
This comment has been minimized.
Quim Muntal (qmuntal)
approved these changes
Oct 20, 2026
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Invalid Go construction examples and an inaccurate constructor error-handling note need correction.
2 open issues
What changed in this PR
Updates the .NET-to-Go symbol catalog to reflect existing Go APIs without changing SDK behavior.
Changes:
- Maps session state counting and skills caching options.
- Adds chat-history memory provider, configuration, state, and scope assessments.
- Documents Go-specific adaptations.
| File | Description |
|---|---|
_catalog/dotnet-go-sdk-symbol-mapping.json |
Refreshes API mappings, examples, and adaptation notes. |
Review effort: Balanced
| "go_symbols": [], | ||
| "status": "unmapped", | ||
| "unreviewed": true | ||
| "go": "agent/skills.ContextProviderOptions{}", |
| "go": "memory.NewHistoryProvider(store, \"history\", dims, stateInit, memory.Config{})", | ||
| "go_symbols": ["agent/memory.HistoryProvider", "agent/memory.NewHistoryProvider"], | ||
| "status": "adapted", | ||
| "note": "Go returns the provider and an error instead of throwing; it stores through the shared vectordata.Store/Collection abstractions rather than VectorStore/VectorStoreCollection." |
Quim Muntal (qmuntal)
removed this pull request from the merge queue due to a manual request
Oct 20, 2026
Member
|
Copilot fix PR review comments |
Co-authored-by: qmuntal <3747816+qmuntal@users.noreply.github.com>
Contributor
Fixed both review findings in commit |
Quim Muntal (qmuntal)
approved these changes
Oct 20, 2026
Quim Muntal (qmuntal)
enabled auto-merge
October 20, 2026 10:32
Contributor
API consistency review
This PR only modifies
|
Quim Muntal (qmuntal)
deleted the
symbolmap/weekly-maintenance-20261020-ba281b1defd89395
branch
October 20, 2026 10:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Weekly symbol-mapping maintenance
Reviewed the API-change report (d246604..29b3a1a), the full assessed-mapping catalog, reconcile.json, and the recent-commits patch against the pinned .NET baseline (
agent-framework@6a0773ba2180e8036d138dbb9794ae64ec2d978b).Corrected stale assessments
Microsoft.Agents.AI.Abstractions.AgentSessionStateBag.Count— wasunmapped("Session's state map is private and exposes no public key-count accessor"). Go addedagent.Session.Count()(agent/session.go:121, covered byTestSessionState_Count_TracksValues). Nowmapped.Microsoft.Agents.AI.Skills.Decorators.CachingAgentSkillsSourceOptions(type,CacheIsolationKeySelector,RefreshInterval, constructor) andAgentSkillsProviderBuilder.UseCachingOptions— wereunreviewed/unmappedwith a stale note claiming "no built-in refresh-interval or cache-isolation-key configuration." Go'sagent/skills.ContextProviderOptionsadded matchingCacheIsolationKeySelectorandRefreshIntervalfields (agent/skills/provider.go), exercised byTestProvider_*CacheIsolationKeySelector*andTestProvider_*RefreshInterval*. Assessed asadapted/mapped.New assessments (previously unreviewed, now implemented in Go)
Microsoft.Agents.AI.Memory.ChatHistoryMemoryProvider(type,StateKeys,Dispose, constructor), its nestedStatetype (and constructor),ChatHistoryMemoryProviderOptions(all properties +SearchBehaviorenum), andChatHistoryMemoryProviderScope(all properties + constructors) — newly inventoried but unassessed .NET declarations. Matched against theagent/memorypackage added in [dotnet-port-api] Add compaction-backed history provider #1092 (agent/memory/provider.go:HistoryProvider,NewHistoryProvider,State,Config,SearchBehavior,Scope). Verified against pinned .NET source (Memory/ChatHistoryMemoryProvider.cs,ChatHistoryMemoryProviderOptions.cs,ChatHistoryMemoryProviderScope.cs) at the baseline commit — confirmed close behavioral parity (vector-store-backed search/storage, scope-based filtering, on-demand vs. before-invoke search tool). Assessed asmapped/adaptedper field, noting Go's*vectordata.Store/error-returning constructor,messagefilter.Filterpointers vs. delegate filters, and pointer-basedScopefields.Checked, no changes needed
agent/harness,agent/harness/filememory,agent/textsearch,agent/skills/fsskills(AgentFileSkillsSourceOptions) packages: already thoroughly assessed in prior PRs ([dotnet-port-api] Add compaction-backed history provider #1092, feat(textsearch): port text search context provider #1286, Add FileMemory storage and editing foundation #1288, Add FileMemory context provider #1290).provider/azureproviderCosmosDB vector-store additions: distinct fromCosmosCheckpointStore/CosmosChatHistoryProvider(declared inMicrosoft.Agents.AI.CosmosNoSql, outside the catalog's inventoried assemblies) — correctlyoutside-inventory-scope, left unchanged.foundryprovider/openaiprovider/otelproviderNewEmbeddingGenerator,EmbeddingGeneratorConfig,NewOpenAIClient,WrapEmbeddingGenerator) have no .NET counterpart in the inventory —Microsoft.Extensions.AI.IEmbeddingGeneratorand related types were never extracted (onlyMicrosoft.Agents.AI,.Abstractions,.Workflowsassemblies are in scope). No catalog edit is possible without an extraction refresh, which is out of scope for this audit.provider/a2aprovider,provider/anthropicprovider,provider/geminiprovider,provider/openaiprovider(chat/responses),provider/otelprovider(otel.go),agent/harness/toolapprovaldiffs in the patch: internal bug fixes / instrumentation wiring only, no new or changed exported API surface.internal/modelcall,internal/telemetry,internal/filestore,internal/storepaths: unexported internal packages, out of scope.Validation
go -C _catalog run ./cmd/symbolmap reconcile -summary -check— passes.git diff --check— passes.Only
_catalog/dotnet-go-sdk-symbol-mapping.jsonis modified. No extraction metadata, declaration keys, test pairs, or unrelated assessments were touched.