Skip to content

[symbolmap] Update weekly symbol mappings - #1281

Merged
George Adams (gdams) merged 2 commits into
mainfrom
symbolmap-weekly-2026-10-13-c13b55306d3d498d
Oct 13, 2026
Merged

George Adams (gdams) merged 2 commits into
mainfrom
symbolmap-weekly-2026-10-13-c13b55306d3d498d

Conversation

@microsoft-agent-framework-for-go

Copy link
Copy Markdown
Contributor

Summary

  • Assessed recent A2A session-store support against pinned .NET source microsoft/agent-framework@0c9944cc9f577d51277ac7c55dbc388b60a577af and Go commit bcee90f28712cf68569ba86884afa7c29f2f0211, mapping AgentSessionStore type plus GetSessionAsync/SaveSessionAsync to provider/a2aprovider.SessionStore and marking GetOrCreateSessionAsync partial because creation is executor composition.
  • Updated WorkflowBuilder.Build(bool) -> Workflow from partial to adapted using workflow.Builder.BuildWithOptions and workflow.BuildOptions, supported by [dotnet-port-api] Support optional workflow orphan validation #1272 and its review comments confirming the final DisableOrphanValidation design.
  • Added Go-only provider/a2aprovider.WithConfiguration, whose source exposes A2A send configuration as a Go agent option while the pinned .NET handler forwards that configuration internally rather than through a public declaration.

Evidence and coverage

  • Inputs initialized: UTC start 2026-10-13T09:06:42Z; original assessed-mappings.json page.total was 1043; extraction hash unchanged at aee1d5164814288ab9a479b2c726661a1d5237266f8ec2aec9be9b090985e72c.
  • Recent API coverage: reviewed all 27/27 go-api-changes.json entries by original array index. IDs 0-7 were already covered/no stale deletion; IDs 8-20 were A2A-reviewed with new action for AgentSessionStore/WithConfiguration; IDs 21-24 were hosted MCP approval APIs with external Microsoft.Extensions.AI counterparts outside catalog inventory, so no Go-only entry; IDs 25-26 updated the workflow assessment.
  • Recent commit/file evidence: source-backed edits cite provider/a2aprovider/sessionstore.go, provider/a2aprovider/executor.go, provider/a2aprovider/handler.go, and workflow/builder.go; reviewed patch commit/file evidence for bcee90f28712cf68569ba86884afa7c29f2f0211, 5a63321c3f3fd1f4f41acfe1ca901c05965a80dd, and bb19f85c6c65e01b750764a35a9f3428dfd087ce where relevant.
  • Original leaf coverage: reconciliation after edits reports 1047 assessed declarations, 0 needs-reconciliation, and 1019 remaining unreviewed placeholders; the substantive source-backed original-leaf changes in this PR are 4 newly assessed AgentSessionStore leaves and 1 corrected workflow leaf.
  • New assessments: 4 .NET leaves assessed from unreviewed placeholders, 1 existing .NET assessment corrected, and 1 new Go-only assessment added. AgentSessionStoreKey, GetService overloads, and DelegatingAgentSessionStore placeholders remain unreviewed because Go has no exported partition-key, service-discovery, or delegating-store counterpart.
  • Duplicate checks: searched issues and PRs for AgentSessionStore/SessionStore, BuildWithOptions/WorkflowBuilder/validateOrphans, and WithConfiguration/a2aprovider names. [dotnet-port-api] Support optional workflow orphan validation #1272 is an implementation PR without mapping edits and therefore does not duplicate this catalog update; no suppressing mapping PR or issue was found.

Validation

  • go -C _catalog run ./cmd/symbolmap reconcile -summary -check
  • git diff --check

Only _catalog/dotnet-go-sdk-symbol-mapping.json is committed. Pre-existing .github/skills/dotnet-symbols/SKILL.md and .github/agents/symbolmap-reviewer.agent.md worktree changes were left unstaged.

Warning

Firewall blocked 2 domains

The following domains were blocked by the firewall during workflow execution:

  • proxy.golang.org
  • storage.googleapis.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "proxy.golang.org"
    - "storage.googleapis.com"

See Network Configuration for more information.

Generated by Weekly Symbol Mapping Maintenance · copilot · gpt55 · 750.9 AIC · ⌖ 17 AIC · ⊞ 23.2K · ◷

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions github-actions Bot added the size:medium At most 100 changed lines across at most 5 files label Oct 13, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot added the kind:docs Changes documentation or comments label Oct 13, 2026
@gdams
George Adams (gdams) marked this pull request as ready for review October 13, 2026 15:14
Copilot AI balanced review requested due to automatic review settings October 13, 2026 15:14
@gdams
George Adams (gdams) requested a review from a team as a code owner October 13, 2026 15:14
@gdams
George Adams (gdams) added this pull request to the merge queue Oct 13, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The GetOrCreateSessionAsync example omits the session-creation branch claimed by its mapping.

1 open finding
What changed in this PR

Updates the symbol catalog with newly assessed A2A session-store mappings, a Go-only configuration option, and revised workflow build parity.

Changes:

  • Maps A2A session persistence APIs.
  • Records WithConfiguration as Go-only.
  • Updates workflow orphan-validation mapping.
File Description
_catalog/​dotnet-go-sdk-symbol-mapping.json Updates A2A and workflow symbol assessments.

🧠 Review effort: Balanced


💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

"go_symbols": [],
"status": "unmapped",
"unreviewed": true
"go": "session, err = store.Get(ctx, contextID)",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot fix these comments

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the example to create a session when the lookup succeeds but returns nil. Committed as 4f350d9.

@gdams
George Adams (gdams) removed this pull request from the merge queue due to a manual request Oct 13, 2026
Co-authored-by: gdams <20224954+gdams@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

API consistency review

Result Scope
out of scope internal-only

This PR's only change (relative to its merge base) is to _catalog/dotnet-go-sdk-symbol-mapping.json, a symbol-mapping catalog/data file used by internal tooling. No public Go API, exported identifiers, or user-visible runtime behavior is modified, so no cross-repo API/behavior parity review is applicable.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • github.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "github.com"

See Network Configuration for more information.

Generated by Go API Consistency Review Agent for #1281 · copilot · auto · 30.6 AIC · ⌖ 7.59 AIC · ⊞ 13.9K · ◷

@gdams
George Adams (gdams) added this pull request to the merge queue Oct 13, 2026
Merged via the queue into main with commit 8a1da8e Oct 13, 2026
28 checks passed
@gdams
George Adams (gdams) deleted the symbolmap-weekly-2026-10-13-c13b55306d3d498d branch October 13, 2026 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind:docs Changes documentation or comments size:medium At most 100 changed lines across at most 5 files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants