Remove the unused strings from C# templates#6600
Open
lauren-ciha wants to merge 4 commits into
Open
Conversation
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
lauren-ciha
force-pushed
the
user/laurenciha/csharp-wizard-cleanup
branch
from
3b0b330 to
cfc6589
Compare
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to remove localized string resources that were only used by the template wizard in the C# VS templates, and adds a clarifying comment in the shared wizard implementation about when ProjectFinishedGenerating is used.
Changes:
- Added a brief comment explaining the purpose of the
ProjectFinishedGeneratinghook in the shared wizard implementation. - Removed several NuGet-installation-related string resources (IDs 1044–1054) from the C# extension’s
VSPackage.resx.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| dev/Templates/VSIX/Shared/WizardImplementation.cs | Adds a clarifying comment for the project-generation event hook used by the wizard. |
| dev/Templates/VSIX/Extension/Cs/Common/VSPackage.resx | Removes unused wizard-related string resources from the C# template extension resources. |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
lauren-ciha
force-pushed
the
user/laurenciha/csharp-wizard-cleanup
branch
from
059a8ea to
2dcfc0b
Compare
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
lauren-ciha
force-pushed
the
user/laurenciha/csharp-wizard-cleanup
branch
from
2dcfc0b to
85c9043
Compare
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the strings that were only used by the template wizard in the C# VS templates.
A microsoft employee must use /azp run to validate using the pipelines below.
WARNING:
Comments made by azure-pipelines bot maybe inaccurate.
Please see pipeline link to verify that the build is being ran.
For status checks on the main branch, please use TransportPackage-Foundation-PR
(https://microsoft.visualstudio.com/ProjectReunion/_build?definitionId=81063&_a=summary)
and run the build against your PR branch with the default parameters.