This repository was archived by the owner on Mar 23, 2026. It is now read-only.
feat: Implement validation for taskweaver_config.json - #511
Merged
Liqun Li (liqul) merged 2 commits intoJan 7, 2026
Merged
Conversation
Liqun Li (liqul)
approved these changes
Jan 7, 2026
Liqun Li (liqul)
left a comment
Liqun Li (liqul)
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the contribution.
Liqun Li (liqul)
added a commit
to liqul/TaskWeaver-Plus
that referenced
this pull request
Feb 3, 2026
### Description This PR addresses the `TODO` in [taskweaver/utils/app_utils.py](cci:7://file:///c:/Users/singh/OneDrive/Documents/Open%20Source/TaskWeaver/taskweaver/utils/app_utils.py:0:0-0:0) by implementing validation logic for the `taskweaver_config.json` file. ### Changes - Implemented `json.load` to verify the configuration file contains valid JSON. - Added a check to ensure the root element is a dictionary ([dict](cci:1://file:///c:/Users/singh/OneDrive/Documents/Open%20Source/TaskWeaver/taskweaver/session/session.py:357:4-362:9)), as expected for configuration files. - Added error handling for `json.JSONDecodeError` and `OSError` to prevent crashes when reading the file. ### Related Issues Resolves TODO in `taskweaver/utils/app_utils.py`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the
TODOin taskweaver/utils/app_utils.py by implementing validation logic for thetaskweaver_config.jsonfile.Changes
json.loadto verify the configuration file contains valid JSON.json.JSONDecodeErrorandOSErrorto prevent crashes when reading the file.Related Issues
Resolves TODO in
taskweaver/utils/app_utils.py