Guard finalizer against partial construction - #447
Open
Scott Lerch (scottlerch) wants to merge 1 commit into
Open
Guard finalizer against partial construction#447Scott Lerch (scottlerch) wants to merge 1 commit into
Scott Lerch (scottlerch) wants to merge 1 commit into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent
RecyclableMemoryStreamfinalization from throwing when construction fails before required fields are initialized.Changes
Dispose(bool)when eithermemoryManagerorblocksis null.Testing
dotnet build Microsoft.IO.RecyclableMemoryStream.sln --configuration Debug --no-restoredotnet test Microsoft.IO.RecyclableMemoryStream.sln --configuration Debug --no-build --no-restoreFixes #446