Recurring time window filter - #73
Merged
Zhiyuan Liang (zhiyuanliang-ms) merged 13 commits intoAug 12, 2025
Merged
Conversation
Zhiyuan Liang (zhiyuanliang-ms)
marked this pull request as ready for review
December 10, 2024 10:54
Zhiyuan Liang (zhiyuanliang-ms)
requested review from
linglingye001 and
Ross Grambo (rossgrambo)
December 10, 2024 10:55
Zhiyuan Liang (zhiyuanliang-ms)
requested review from
Junbo Wang (juniwang) and
Matthew Metcalf (mrm9084)
December 11, 2024 07:14
There was a problem hiding this comment.
Copilot reviewed 8 out of 18 changed files in this pull request and generated no suggestions.
Files not reviewed (10)
- package.json: Language not supported
- src/filter/TimeWindowFilter.ts: Evaluated as low risk
- src/featureManager.ts: Evaluated as low risk
- test/noFilters.test.ts: Evaluated as low risk
- test/featureManager.test.ts: Evaluated as low risk
- test/targetingFilter.test.ts: Evaluated as low risk
- src/index.ts: Evaluated as low risk
- src/filter/targetingFilter.ts: Evaluated as low risk
- src/filter/recurrence/validator.ts: Evaluated as low risk
- src/filter/utils.ts: Evaluated as low risk
Comments skipped due to low confidence (5)
src/filter/recurrence/evaluator.ts:32
- [nitpick] The function name 'FindPreviousRecurrence' should be in camelCase to maintain consistency with the rest of the codebase. Consider renaming it to 'findPreviousRecurrence'.
function FindPreviousRecurrence(time: Date, recurrenceSpec: RecurrenceSpec): RecurrenceState | undefined {
src/filter/recurrence/evaluator.ts:60
- [nitpick] The function name 'FindPreviousDailyRecurrence' should be in camelCase to maintain consistency with the rest of the codebase. Consider renaming it to 'findPreviousDailyRecurrence'.
function FindPreviousDailyRecurrence(time: Date, recurrenceSpec: RecurrenceSpec): RecurrenceState {
src/filter/recurrence/evaluator.ts:43
- The error message 'Unsupported recurrence pattern type.' could be more specific. Consider providing the unsupported pattern type in the message.
throw new Error("Unsupported recurrence pattern type.");
src/filter/timeWindowFilter.ts:21
- [nitpick] The type name 'RecurrenceParameter' is inconsistent with the naming convention of other parameter types. Consider renaming it to 'RecurrenceParameters'.
export type RecurrenceParameter = {
src/filter/recurrence/utils.ts:34
- [nitpick] The parameter name 'timezoneOffset' is ambiguous as it is in milliseconds. Consider renaming it to 'timezoneOffsetInMs' or adding a comment to clarify.
export function getDayOfWeek(date: Date, timezoneOffset: number): number {
…-JavaScript into zhiyuanliang/recurring-time-window
…-JavaScript into zhiyuanliang/recurring-time-window
…-JavaScript into zhiyuanliang/recurring-time-window
…-JavaScript into zhiyuanliang/recurring-time-window
Ross Grambo (rossgrambo)
previously approved these changes
Aug 11, 2025
Ross Grambo (rossgrambo)
approved these changes
Aug 12, 2025
Zhiyuan Liang (zhiyuanliang-ms)
deleted the
zhiyuanliang/recurring-time-window
branch
August 12, 2025 02:05
Zhiyuan Liang (zhiyuanliang-ms)
added a commit
that referenced
this pull request
Aug 20, 2025
* Merge pull request #124 from microsoft/zhiyuanliang/unify-naming-convention Unify filename naming * correct file name (#125) * Recurring time window filter (#73) * WIP: validation finished * update filename * WIP: evaluation done * add testcases * fix lint * update method name * update * revert change * version bump (#126)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this PR?
Support recurrence for time window filter. Also renamed some files to follow the naming convention.
Time window filter schema: https://github.com/microsoft/FeatureManagement/blob/main/Schema/FeatureFilters/Microsoft.TimeWindow.v2.0.0.schema.json
Reference:
#266
#522
Doc