Ship Microsoft.ApplicationInsights.dll with Microsoft.Build.Sql SDK#798
Merged
llali merged 1 commit intoJun 4, 2026
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Microsoft.Build.Sql MSBuild SDK packaging process to ensure Microsoft.ApplicationInsights.dll is staged into the SDK’s NuGet tools/ assets, so DacFx tasks can resolve it at build time even when transitive dependencies are suppressed.
Changes:
- Adds central package version pin for
Microsoft.ApplicationInsights(2.23.0). - Adds a
PackageReferencewithGeneratePathProperty="true"to enable staging from the restored package. - Copies
Microsoft.ApplicationInsights.dllinto the SDK staging output for bothnet8.0andnet472.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Microsoft.Build.Sql/Microsoft.Build.Sql.csproj | Adds ApplicationInsights package reference and stages the DLL into the SDK’s tools/ output for net8.0 and net472. |
| Directory.Packages.props | Pins Microsoft.ApplicationInsights to 2.23.0 via central package management. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
llali
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
Microsoft.ApplicationInsights(2.23.0) as a runtime asset that is staged into theMicrosoft.Build.SqlSDK NuGet package, so the DacFx tasks loaded by consumers can resolveMicrosoft.ApplicationInsights.dllat build time using MSBuild.Background
src/Microsoft.Build.Sql/Microsoft.Build.Sql.csprojbuilds an MSBuild SDK and setsSuppressDependenciesWhenPacking=true, so transitive NuGet dependencies are not surfaced to the sqlproj that consumes the SDK.Microsoft.ApplicationInsights. Without explicitly staging the assembly, consumer builds rely on transitive resolution that is not guaranteed in every host.Changes
PackageVersionforMicrosoft.ApplicationInsights2.23.0 inDirectory.Packages.props.PackageReference(withGeneratePathProperty="true") insrc/Microsoft.Build.Sql/Microsoft.Build.Sql.csproj.Microsoft.ApplicationInsights.dllinto bothtools/net8.0/(fromlib/netstandard2.0) andtools/net472/(fromlib/net46).Backward Compatibility
Code Changes
dotnet testonMicrosoft.Build.Sql.Testsnet8.0: 72/72 passed).