Confirming ML-KEM handshakes in AL3 and AL4 - #8152
Merged
Merged
Conversation
Co-authored-by: maxtropets <16566519+maxtropets@users.noreply.github.com>
Co-authored-by: maxtropets <16566519+maxtropets@users.noreply.github.com>
Co-authored-by: maxtropets <16566519+maxtropets@users.noreply.github.com>
Co-authored-by: maxtropets <16566519+maxtropets@users.noreply.github.com>
Co-authored-by: maxtropets <16566519+maxtropets@users.noreply.github.com>
Co-authored-by: maxtropets <16566519+maxtropets@users.noreply.github.com>
Co-authored-by: maxtropets <16566519+maxtropets@users.noreply.github.com>
Co-authored-by: maxtropets <16566519+maxtropets@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
Max (maxtropets)
August 13, 2026 13:51
View session
Amaury Chamayou (achamayou)
approved these changes
Aug 13, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the TEST_HYBRID_TLS_GROUPS gating flag and makes the hybrid ML‑KEM TLS group negotiation checks run by default, updating the openssl s_client output parsing so hybrid groups can be identified reliably on Azure Linux 3 (OpenSSL 3.3) as well as Azure Linux 4.
Changes:
- Always run the hybrid TLS group unit test and the
tls_groups_teste2e test (removing the CMake option and CI flag wiring). - Update
tests/tls_groups.pyto runopenssl s_clientwith-traceand map OpenSSL 3.3 “UNKNOWN (id)” NamedGroup IDs back to expected group names. - Add
tls_groups_testto CI bucket routing and remove the now-unused CI flag in AL4 workflow.
Custom instructions used:
.github/copilot-instructions.md.github/instructions/reviewing.instructions.md
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
tests/tls_groups.py |
Parses openssl s_client -trace output and maps NamedGroup IDs to names to validate hybrid negotiation on OpenSSL 3.3/3.5. |
tests/ci-buckets.txt |
Ensures tls_groups_test is scheduled in bucket_a. |
src/tls/test/main.cpp |
Removes skip gate so hybrid group negotiation unit test always runs. |
CMakeLists.txt |
Removes TEST_HYBRID_TLS_GROUPS option and always registers tls_groups_test. |
.github/workflows/ci-al4.yml |
Drops -DTEST_HYBRID_TLS_GROUPS=ON from AL4 CI configuration. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the flag. As for .py change:
Can go when fully migrated to AL4 tho, it seems to detect correctly there.