Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decorating a functools.partial currently applies update_wrapper directly to the original partial. This adds wrapped and changes inspect.signature(original) from the remaining arguments to the full underlying function signature. Decorating the same partial again then validates calls against the wrong signature and can reject valid calls.
Copy the partial and its attribute dictionary before copying wrapper metadata. The explicit dictionary copy also preserves partials that already have custom attributes without mutating their metadata. Add a regression that decorates the same partial twice, checks signatures and custom attributes, and calls both wrappers.
Validation on Python 3.12.14: the regression fails before the fix with (x, y) != (y). All 29 tests in tests/test.py pass after the fix; git diff --check passes.