Repository navigation
Preserve deferred annotations in FunctionMaker and decoratorx - #194
Open
mayankdhingra02 wants to merge 1 commit into
Open
mayankdhingra02 wants to merge 1 commit into
mayankdhingra02 wants to merge 1 commit into
Conversation
Keep unresolved annotations from preventing FunctionMaker from generating a wrapper. Forward the original annotation callback so its names can resolve later in the original globals and closure, including through decoratorx. Keep the existing annotation mapping for concrete and string annotations. Cover deferred generic annotations, later definitions, stacked and async wrappers, and annotations that capture local classes. Fixes micheles#177. Signed-off-by: Mayank Dhingra <mayankdhingra02@gmail.com>
Owner
|
Thank you for your contribution, it is a good idea but I would make some minor change. It will be back on this in a few days, now I am travelling. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
decoratorxstill readsfunc.__annotations__while generating a wrapper,which raises
NameErrorwhen deferred annotations reference names importedonly under
TYPE_CHECKING.When that happens, keep the original
__annotate__callback on the generatedfunction. This lets decoration and calls succeed while allowing annotations
to resolve later against the original globals and captured locals. Concrete
and future-string annotations retain their existing dictionary identity.
Fixes #177.
Verification:
stacked wrappers, captured local classes and async wrappers, plus controls
for concrete and string annotations. Four cases fail before the fix.
PYTHONPATH=src python tests/test.py -vpasses on Python 3.8 through3.15, including all documentation doctests. Deferred-only tests skip on
versions before 3.14.
python -m mypy.stubtest decoratorand
python -m mypy src/decorator/__init__.pyall pass.